|
Christian Heimes
2010-06-21, 15:00
Michael McCandless
2010-06-21, 15:30
Christian Heimes
2010-06-22, 15:14
Andi Vajda
2010-06-22, 15:42
Christian Heimes
2010-06-22, 16:47
Andi Vajda
2010-06-23, 15:26
Christian Heimes
2010-06-24, 13:59
Michael McCandless
2010-06-24, 14:21
Andi Vajda
2010-06-25, 09:49
|
-
Re: [VOTE] Release PyLucene 2.9.3-1 and 3.0.2-1Christian Heimes 2010-06-21, 15:00
> With the recent - simultaneous - releases of Java Lucene 2.9.3 and 3.0.2,
> the PyLucene 2.9.3-1 and 3.0.2-1 releases closely tracking them are ready. I've upgrade PyLucene from 2.9.2 to 2.9.3 and JCC from 2.5.1 to 2.6. Our application stack, unit tests and bobo-browse integration haven't shown any issue. +1 from me Christian
-
Re: [VOTE] Release PyLucene 2.9.3-1 and 3.0.2-1Michael McCandless 2010-06-21, 15:30
+1 to release both
Signatures/MD5 check out, and I built & installed each on OS X 10.6.3, and ran my usual smoke test (indexing first 100K docs from Wikipedia & running a few queries & confirming search results are identical between the two versions). Mike On Fri, Jun 18, 2010 at 1:47 PM, Andi Vajda <[EMAIL PROTECTED]> wrote: > > With the recent - simultaneous - releases of Java Lucene 2.9.3 and 3.0.2, > the PyLucene 2.9.3-1 and 3.0.2-1 releases closely tracking them are ready. > > Release candidates are available from: > > http://people.apache.org/~vajda/staging_area/ > > A list of changes in this release can be seen at: > http://svn.apache.org/repos/asf/lucene/pylucene/branches/pylucene_2_9/CHANGES > http://svn.apache.org/repos/asf/lucene/pylucene/branches/pylucene_3_0/CHANGES > > All versions of PyLucene are now built with the same version of JCC, > currently version 2.6, included in these release artifacts. > > A list of Lucene Java changes can be seen at: > http://svn.apache.org/repos/asf/lucene/java/branches/lucene_2_9/CHANGES.txt > http://svn.apache.org/repos/asf/lucene/java/branches/lucene_3_0/CHANGES.txt > > Please vote to release these artifacts as PyLucene 2.9.3-1 and 3.0.2-1. > > Thanks ! > > Andi.. > > ps: the KEYS file for PyLucene release signing is at: > http://svn.apache.org/repos/asf/lucene/pylucene/dist/KEYS > http://people.apache.org/~vajda/staging_area/KEYS > > pps: here is my +1 >
-
Re: [VOTE] Release PyLucene 2.9.3-1 and 3.0.2-1Christian Heimes 2010-06-22, 15:14
Am 21.06.2010 17:00, schrieb Christian Heimes:
>> With the recent - simultaneous - releases of Java Lucene 2.9.3 and 3.0.2, >> the PyLucene 2.9.3-1 and 3.0.2-1 releases closely tracking them are ready. > > I've upgrade PyLucene from 2.9.2 to 2.9.3 and JCC from 2.5.1 to 2.6. Our > application stack, unit tests and bobo-browse integration haven't shown > any issue. > > +1 from me I'm sorry to inform you, that I have to retract my +1. A full rebuild of JCC, PyLucene and Bobo has revealed an issue. I haven't noticed the issue before because I forgot to update to PyLucene 2.9.3 on my bobo-browse test box. The build error is a regression from PyLucene 2.9.2 to 2.9.3. python2.6 -m jcc.__main__ --shared --jar bobo-browse-2.5.0-rc1/dist/bobo-browse-2.5.0-rc1.jar --include bobo-browse-2.5.0-rc1/lib/master/servlet-api.jar --include bobo-browse-2.5.0-rc1/lib/master/spring-webmvc.jar --include bobo-browse-2.5.0-rc1/lib/master/spring.jar --include bobo-browse-2.5.0-rc1/lib/master/log4j.jar --include bobo-browse-2.5.0-rc1/lib/master/protobuf-java-2.2.0.jar --include bobo-browse-2.5.0-rc1/lib/master/xstream.jar --include bobo-browse-2.5.0-rc1/lib/master/fastutil.jar --include bobo-browse-2.5.0-rc1/lib/master/kamikaze-2.0.0.jar --classpath bobo-browse-2.5.0-rc1/lib/master/ant.jar --classpath bobo-browse-2.5.0-rc1/lib/master/xercesImpl.jar --classpath bobo-browse-2.5.0-rc1/lib/master/commons-collections.jar --classpath bobo-browse-2.5.0-rc1/lib/master/commons-cli.jar --classpath bobo-browse-2.5.0-rc1/lib/master/commons-configuration.jar --classpath bobo-browse-2.5.0-rc1/lib/master/commons-logging.jar --classpath bobo-browse-2.5.0-rc1/lib/master/commons-lang.jar --classpath bobo-browse-2.5.0-rc1/lib/master/commons-digester.jar --classpath bobo-browse-2.5.0-rc1/lib/master/commons-httpclient.jar --classpath bobo-browse-2.5.0-rc1/lib/master/zoie-2.0.0-rc1.jar --classpath bobo-browse-2.5.0-rc1/lib/master/json.jar --classpath bobo-browse-2.5.0-rc1/lib/master/dwr.jar --classpath bobo-browse-2.5.0-rc1/lib/master/xmlParserAPIs.jar --package java.util java.util.LinkedHashSet java.util.LinkedList --exclude com.browseengine.bobo.facets.FacetHandler\$TermCountSize --import lucene --python bobo --version 2.5.0-rc1 --files 2 --build Warning: renaming static method 'toString' on class com.browseengine.bobo.api.BrowseResult to 'toString_' since it is shadowed by non-static method of same name. running build_ext building 'bobo._bobo' extension creating build/temp.linux-x86_64-2.6 creating build/temp.linux-x86_64-2.6/build creating build/temp.linux-x86_64-2.6/build/_bobo gcc -pthread -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fPIC -D_java_generics -DPYTHON=1 -D_jcc_shared=1 -I/usr/lib/jvm/java-6-sun/include -I/usr/lib/jvm/java-6-sun/include/linux -Ibuild/_bobo -I/usr/local/lib/python2.6/dist-packages/JCC-2.6-py2.6-linux-x86_64.egg/jcc/sources -I/usr/local/lib/python2.6/dist-packages/lucene-2.9.3-py2.6-linux-x86_64.egg/lucene/include -I/usr/include/python2.6 -c build/_bobo/functions.cpp -o build/temp.linux-x86_64-2.6/build/_bobo/functions.o -fno-strict-aliasing -Wno-write-strings cc1plus: warning: command line option "-Wstrict-prototypes" is valid for Ada/C/ObjC but not for C++ In file included from /usr/include/python2.6/Python.h:8, from /usr/local/lib/python2.6/dist-packages/JCC-2.6-py2.6-linux-x86_64.egg/jcc/sources/JCCEnv.h:47, from /usr/local/lib/python2.6/dist-packages/JCC-2.6-py2.6-linux-x86_64.egg/jcc/sources/JObject.h:21, from /usr/local/lib/python2.6/dist-packages/lucene-2.9.3-py2.6-linux-x86_64.egg/lucene/include/java/lang/Object.h:4, from build/_bobo/functions.cpp:18: /usr/include/python2.6/pyconfig.h:1031:1: warning: "_POSIX_C_SOURCE" redefined In file included from /usr/include/stdio.h:28, from /usr/lib/jvm/java-6-sun/include/jni.h:21, from build/_bobo/functions.cpp:15: /usr/include/features.h:158:1: warning: this is the location of the previous definition In file included from /usr/include/python2.6/Python.h:8, from /usr/local/lib/python2.6/dist-packages/JCC-2.6-py2.6-linux-x86_64.egg/jcc/sources/JCCEnv.h:47, from /usr/local/lib/python2.6/dist-packages/JCC-2.6-py2.6-linux-x86_64.egg/jcc/sources/JObject.h:21, from /usr/local/lib/python2.6/dist-packages/lucene-2.9.3-py2.6-linux-x86_64.egg/lucene/include/java/lang/Object.h:4, from build/_bobo/functions.cpp:18: /usr/include/python2.6/pyconfig.h:1040:1: warning: "_XOPEN_SOURCE" redefined In file included from /usr/include/stdio.h:28, from /usr/lib/jvm/java-6-sun/include/jni.h:21, from build/_bobo/functions.cpp:15: /usr/include/features.h:160:1: warning: this is the location of the previous definition In file included from build/_bobo/functions.cpp:32: /usr/local/lib/python2.6/dist-packages/JCC-2.6-py2.6-linux-x86_64.egg/jcc/sources/functions.h: In function �PyObject* get_generic_iterator(T*)�: /usr/local/lib/python2.6/dist-packages/JCC-2.6-py2.6-linux-x86_64.egg/jcc/sources/functions.h:138: error: no matching function for call to �java::util::t_Iterator::wrap_jobject(_jobject*&, PyTypeObject*&)� /usr/local/lib/python2.6/dist-packages/lucene-2.9.3-py2.6-linux-x86_64.egg/lucene/include/java/util/Iterator.h:53: note: candidates are: static PyObject* java::util::t_Iterator::wrap_jobject(_jobject* const&) error: command 'gcc' failed with exit status 1
-
Re: [VOTE] Release PyLucene 2.9.3-1 and 3.0.2-1Andi Vajda 2010-06-22, 15:42
On Tue, 22 Jun 2010, Christian Heimes wrote: > Am 21.06.2010 17:00, schrieb Christian Heimes: >>> With the recent - simultaneous - releases of Java Lucene 2.9.3 and 3.0.2, >>> the PyLucene 2.9.3-1 and 3.0.2-1 releases closely tracking them are ready. >> >> I've upgrade PyLucene from 2.9.2 to 2.9.3 and JCC from 2.5.1 to 2.6. Our >> application stack, unit tests and bobo-browse integration haven't shown >> any issue. >> >> +1 from me > > I'm sorry to inform you, that I have to retract my +1. A full rebuild of > JCC, PyLucene and Bobo has revealed an issue. I haven't noticed the > issue before because I forgot to update to PyLucene 2.9.3 on my > bobo-browse test box. The build error is a regression from PyLucene > 2.9.2 to 2.9.3. The issue has to do with the fact that PyLucene 2.9.3 is built with generics support turned off (passing --no-generics to jcc) by default since Lucene 2.9.3 makes no use of generics and is thus supported with Java 1.4 as well. If you --import lucene built with --no-generics you also must use --no-generics when building bobo. You can also change PyLucene 2.9.3's Makefile to not use --no-generics or switch to PyLucene 3.0.2 which uses Lucene 3.0.2, a version of Lucene that requires Java 1.5 and uses generics. Andi.. > > python2.6 -m jcc.__main__ --shared --jar > bobo-browse-2.5.0-rc1/dist/bobo-browse-2.5.0-rc1.jar --include > bobo-browse-2.5.0-rc1/lib/master/servlet-api.jar --include > bobo-browse-2.5.0-rc1/lib/master/spring-webmvc.jar --include > bobo-browse-2.5.0-rc1/lib/master/spring.jar --include > bobo-browse-2.5.0-rc1/lib/master/log4j.jar --include > bobo-browse-2.5.0-rc1/lib/master/protobuf-java-2.2.0.jar --include > bobo-browse-2.5.0-rc1/lib/master/xstream.jar --include > bobo-browse-2.5.0-rc1/lib/master/fastutil.jar --include > bobo-browse-2.5.0-rc1/lib/master/kamikaze-2.0.0.jar --classpath > bobo-browse-2.5.0-rc1/lib/master/ant.jar --classpath > bobo-browse-2.5.0-rc1/lib/master/xercesImpl.jar --classpath > bobo-browse-2.5.0-rc1/lib/master/commons-collections.jar --classpath > bobo-browse-2.5.0-rc1/lib/master/commons-cli.jar --classpath > bobo-browse-2.5.0-rc1/lib/master/commons-configuration.jar --classpath > bobo-browse-2.5.0-rc1/lib/master/commons-logging.jar --classpath > bobo-browse-2.5.0-rc1/lib/master/commons-lang.jar --classpath > bobo-browse-2.5.0-rc1/lib/master/commons-digester.jar --classpath > bobo-browse-2.5.0-rc1/lib/master/commons-httpclient.jar --classpath > bobo-browse-2.5.0-rc1/lib/master/zoie-2.0.0-rc1.jar --classpath > bobo-browse-2.5.0-rc1/lib/master/json.jar --classpath > bobo-browse-2.5.0-rc1/lib/master/dwr.jar --classpath > bobo-browse-2.5.0-rc1/lib/master/xmlParserAPIs.jar --package java.util > java.util.LinkedHashSet java.util.LinkedList --exclude > com.browseengine.bobo.facets.FacetHandler\$TermCountSize --import lucene > --python bobo --version 2.5.0-rc1 --files 2 --build > Warning: renaming static method 'toString' on class > com.browseengine.bobo.api.BrowseResult to 'toString_' since it is > shadowed by non-static method of same name. > running build_ext > building 'bobo._bobo' extension > creating build/temp.linux-x86_64-2.6 > creating build/temp.linux-x86_64-2.6/build > creating build/temp.linux-x86_64-2.6/build/_bobo > gcc -pthread -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall > -Wstrict-prototypes -fPIC -D_java_generics -DPYTHON=1 -D_jcc_shared=1 > -I/usr/lib/jvm/java-6-sun/include > -I/usr/lib/jvm/java-6-sun/include/linux -Ibuild/_bobo > -I/usr/local/lib/python2.6/dist-packages/JCC-2.6-py2.6-linux-x86_64.egg/jcc/sources > -I/usr/local/lib/python2.6/dist-packages/lucene-2.9.3-py2.6-linux-x86_64.egg/lucene/include > -I/usr/include/python2.6 -c build/_bobo/functions.cpp -o > build/temp.linux-x86_64-2.6/build/_bobo/functions.o -fno-strict-aliasing > -Wno-write-strings > cc1plus: warning: command line option "-Wstrict-prototypes" is valid for > Ada/C/ObjC but not for C++ > In file included from /usr/include/python2.6/Python.h:8, > from
-
Re: [VOTE] Release PyLucene 2.9.3-1 and 3.0.2-1Christian Heimes 2010-06-22, 16:47
Am 22.06.2010 17:42, schrieb Andi Vajda:
> The issue has to do with the fact that PyLucene 2.9.3 is built with generics > support turned off (passing --no-generics to jcc) by default since Lucene > 2.9.3 makes no use of generics and is thus supported with Java 1.4 as well. > > If you --import lucene built with --no-generics you also must use > --no-generics when building bobo. > > You can also change PyLucene 2.9.3's Makefile to not use --no-generics or > switch to PyLucene 3.0.2 which uses Lucene 3.0.2, a version of Lucene that > requires Java 1.5 and uses generics. Ah! :) The thing is, bobo browse needs generic support for some features. Our test cases fail when I compile bobo browse without generics. Could you make the option --no-generics a make variable? Something like JCC_ARGS = "--no-generics" GENERATE=$(JCC) $(foreach jar,$(JARS),--jar $(jar)) \ $(JCC_ARGS) \ --package java.lang java.lang.System \ java.lang.Runtime \ ... This way I'm able to overwrite the option with a simple make argument instead of patching the Makefile. It might be wise to remove the default "--no-generics" to keep 2.9.3 compatible with 2.9.2. The option is a new feature. Christian
-
Re: [VOTE] Release PyLucene 2.9.3-1 and 3.0.2-1Andi Vajda 2010-06-23, 15:26
On Tue, 22 Jun 2010, Christian Heimes wrote: > Am 22.06.2010 17:42, schrieb Andi Vajda: >> The issue has to do with the fact that PyLucene 2.9.3 is built with generics >> support turned off (passing --no-generics to jcc) by default since Lucene >> 2.9.3 makes no use of generics and is thus supported with Java 1.4 as well. >> >> If you --import lucene built with --no-generics you also must use >> --no-generics when building bobo. >> >> You can also change PyLucene 2.9.3's Makefile to not use --no-generics or >> switch to PyLucene 3.0.2 which uses Lucene 3.0.2, a version of Lucene that >> requires Java 1.5 and uses generics. > > Ah! :) > > The thing is, bobo browse needs generic support for some features. Our > test cases fail when I compile bobo browse without generics. Could you > make the option --no-generics a make variable? Something like > > JCC_ARGS = "--no-generics" > > GENERATE=$(JCC) $(foreach jar,$(JARS),--jar $(jar)) \ > $(JCC_ARGS) \ > --package java.lang java.lang.System \ > java.lang.Runtime \ > ... > > This way I'm able to overwrite the option with a simple make argument > instead of patching the Makefile. It might be wise to remove the default > "--no-generics" to keep 2.9.3 compatible with 2.9.2. The option is a new > feature. So I added 'JCCFLAGS?=--no-generics' to PyLucene's Makefile and uploaded new release artifacts. Please check them out and let me know if all is working as expected. Thanks ! Andi..
-
Re: [VOTE] Release PyLucene 2.9.3-1 and 3.0.2-1Christian Heimes 2010-06-24, 13:59
> So I added 'JCCFLAGS?=--no-generics' to PyLucene's Makefile and uploaded new
> release artifacts. Please check them out and let me know if all is working > as expected. Thanks a lot! It works like a charm. +1 again ;) Christian
-
Re: [VOTE] Release PyLucene 2.9.3-1 and 3.0.2-1Michael McCandless 2010-06-24, 14:21
+1, again.
Mike On Wed, Jun 23, 2010 at 11:26 AM, Andi Vajda <[EMAIL PROTECTED]> wrote: > > On Tue, 22 Jun 2010, Christian Heimes wrote: > >> Am 22.06.2010 17:42, schrieb Andi Vajda: >>> >>> The issue has to do with the fact that PyLucene 2.9.3 is built with >>> generics >>> support turned off (passing --no-generics to jcc) by default since Lucene >>> 2.9.3 makes no use of generics and is thus supported with Java 1.4 as >>> well. >>> >>> If you --import lucene built with --no-generics you also must use >>> --no-generics when building bobo. >>> >>> You can also change PyLucene 2.9.3's Makefile to not use --no-generics or >>> switch to PyLucene 3.0.2 which uses Lucene 3.0.2, a version of Lucene >>> that >>> requires Java 1.5 and uses generics. >> >> Ah! :) >> >> The thing is, bobo browse needs generic support for some features. Our >> test cases fail when I compile bobo browse without generics. Could you >> make the option --no-generics a make variable? Something like >> >> JCC_ARGS = "--no-generics" >> >> GENERATE=$(JCC) $(foreach jar,$(JARS),--jar $(jar)) \ >> $(JCC_ARGS) \ >> --package java.lang java.lang.System \ >> java.lang.Runtime \ >> ... >> >> This way I'm able to overwrite the option with a simple make argument >> instead of patching the Makefile. It might be wise to remove the default >> "--no-generics" to keep 2.9.3 compatible with 2.9.2. The option is a new >> feature. > > So I added 'JCCFLAGS?=--no-generics' to PyLucene's Makefile and uploaded new > release artifacts. Please check them out and let me know if all is working > as expected. > > Thanks ! > > Andi.. >
-
Re: [VOTE] Release PyLucene 2.9.3-1 and 3.0.2-1Andi Vajda 2010-06-25, 09:49
On Thu, 24 Jun 2010, Michael McCandless wrote: > +1, again. Thank you Mike and Christian for your votes. We are still missing one PMC vote in order to release these artifacts. Grant ? Andi.. > > Mike > > On Wed, Jun 23, 2010 at 11:26 AM, Andi Vajda <[EMAIL PROTECTED]> wrote: >> >> On Tue, 22 Jun 2010, Christian Heimes wrote: >> >>> Am 22.06.2010 17:42, schrieb Andi Vajda: >>>> >>>> The issue has to do with the fact that PyLucene 2.9.3 is built with >>>> generics >>>> support turned off (passing --no-generics to jcc) by default since Lucene >>>> 2.9.3 makes no use of generics and is thus supported with Java 1.4 as >>>> well. >>>> >>>> If you --import lucene built with --no-generics you also must use >>>> --no-generics when building bobo. >>>> >>>> You can also change PyLucene 2.9.3's Makefile to not use --no-generics or >>>> switch to PyLucene 3.0.2 which uses Lucene 3.0.2, a version of Lucene >>>> that >>>> requires Java 1.5 and uses generics. >>> >>> Ah! :) >>> >>> The thing is, bobo browse needs generic support for some features. Our >>> test cases fail when I compile bobo browse without generics. Could you >>> make the option --no-generics a make variable? Something like >>> >>> JCC_ARGS = "--no-generics" >>> >>> GENERATE=$(JCC) $(foreach jar,$(JARS),--jar $(jar)) \ >>> � � � � �$(JCC_ARGS) \ >>> � � � � �--package java.lang java.lang.System \ >>> � � � � � � � � � � � � � � �java.lang.Runtime \ >>> � � � � �... >>> >>> This way I'm able to overwrite the option with a simple make argument >>> instead of patching the Makefile. It might be wise to remove the default >>> "--no-generics" to keep 2.9.3 compatible with 2.9.2. The option is a new >>> feature. >> >> So I added 'JCCFLAGS?=--no-generics' to PyLucene's Makefile and uploaded new >> release artifacts. Please check them out and let me know if all is working >> as expected. >> >> Thanks ! >> >> Andi.. >> > |