What's the workflow for github pull requests?   We can't just apply the patches without the user signing off on the ASL, right?   There still needs to be a JIRA created with a patch that is checked ASL, as I understand it.

Clarification/discussion on this would be good to have.

Erik

On Feb 19, 2012, at 18:31 , Jukka Zitting wrote:

> Hi,
>
> Here's another pull request from GitHub.
>
> BR,
>
> Jukka Zitting
>
> ---------- Forwarded message ----------
> From: Git at Apache <[EMAIL PROTECTED]>
> Date: Sun, Feb 19, 2012 at 4:52 PM
> Subject: lucene-solr pull request: Fixing typo in example schema:
> 'salves' => 'slaves'
> To: [EMAIL PROTECTED]
>
>
> GitHub user JackDanger synchronized the pull request at
> https://github.com/apache/lucene-solr/pull/2
>
> ----
> Fixing typo in example schema: 'salves' => 'slaves'
>
> Just a typo in a comment. Safe to merge.
> ----
>
> You can merge this pull request into a Git repository by running
> $ git pull https://github.com/JackDanger/lucene-solr patch-1
>
> Alternatively you can review and apply these changes as the patch at
> https://github.com/apache/lucene-solr/pull/2.patch
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
---------------------------------------------------------------------

Cool; pull-requests via GitHub.  Has anyone reacted to one of these messages
and applied the change before?  If so what was the process?  Since
lucene-solr is a mirror, is it impossible?

~ David

-----
 Author: http://www.packtpub.com/apache-solr-3-enterprise-search-server/book
--
View this message in context: http://lucene.472066.n3.nabble.com/lucene-solr-pull-request-Fixing-typo-in-example-schema-salves-slaves-tp3760050p3761098.html
Sent from the Lucene - Java Developer mailing list archive at Nabble.com.

---------------------------------------------------------------------

I think the problem is around the ASF's thoughts on what it means to contribute a patch in JIRA and click the check box about donating. They seem to find that important, and you don't have the same mechanism when grabbing pull requests from github.

On Feb 20, 2012, at 10:56 AM, David Smiley (@MITRE.org) wrote:

> Cool; pull-requests via GitHub.  Has anyone reacted to one of these messages
> and applied the change before?  If so what was the process?  Since
> lucene-solr is a mirror, is it impossible?
>
> ~ David
>
> -----
> Author: http://www.packtpub.com/apache-solr-3-enterprise-search-server/book
> --
> View this message in context: http://lucene.472066.n3.nabble.com/lucene-solr-pull-request-Fixing-typo-in-example-schema-salves-slaves-tp3760050p3761098.html
> Sent from the Lucene - Java Developer mailing list archive at Nabble.com.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>

- Mark Miller
lucidimagination.com


---------------------------------------------------------------------

Ok, that's disappointing.  So much for ASF projects being part of the social coding revolution.  It's a big deal, by the way.  When people ask me what it's all about, I point them to this blob post by the Springframework team: http://blog.springsource.com/2010/12/21/social-coding-in-spring-projects/
I suspect you are enlightened Mark but others reading our conversation might not be.

So this guy's patch, the one I replied to, is a typo amounting to two characters.  Are there ASF guidelines on size of contributions?  Wether guidelines exist or not, IANAL but I believe there are practical considerations on the size of patches to not concern yourself with copyright.  I've seen estimates before ranging from 20-100 lines of code.

~ David

On Feb 20, 2012, at 11:07 AM, Mark Miller-3 [via Lucene] wrote:

I think the problem is around the ASF's thoughts on what it means to contribute a patch in JIRA and click the check box about donating. They seem to find that important, and you don't have the same mechanism when grabbing pull requests from github.

On Feb 20, 2012, at 10:56 AM, David Smiley (@MITRE.org) wrote:

> Cool; pull-requests via GitHub.  Has anyone reacted to one of these messages
> and applied the change before?  If so what was the process?  Since
> lucene-solr is a mirror, is it impossible?
>
> ~ David
>
> -----
> Author: http://www.packtpub.com/apache-solr-3-enterprise-search-server/book
> --
> View this message in context: http://lucene.472066.n3.nabble.com/lucene-solr-pull-request-Fixing-typo-in-example-schema-salves-slaves-tp3760050p3761098.html
> Sent from the Lucene - Java Developer mailing list archive at Nabble.com<http://Nabble.com>.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]<x-msg://101/user/SendEmail.jtp?type=node&node=3761133&i=0>
> For additional commands, e-mail: [hidden email]<x-msg://101/user/SendEmail.jtp?type=node&node=3761133&i=1>
>

- Mark Miller
lucidimagination.com<http://lucidimagination.com>


---------------------------------------------------------------------

________________________________
If you reply to this email, your message will be added to the discussion below:
http://lucene.472066.n3.nabble.com/lucene-solr-pull-request-Fixing-typo-in-example-schema-salves-slaves-tp3760050p3761133.html
To unsubscribe from lucene-solr pull request: Fixing typo in example schema: 'salves' => 'slaves', click here<http://lucene.472066.n3.nabble.com/template/NamlServlet.jtp?macro=unsubscribe_by_code&node=3760050&code=RFNNSUxFWUBtaXRyZS5vcmd8Mzc2MDA1MHwxMDE2NDI2OTUw>.
NAML<http://lucene.472066.n3.nabble.com/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml>

-----
 Author: http://www.packtpub.com/apache-solr-3-enterprise-search-server/book
--
View this message in context: http://lucene.472066.n3.nabble.com/lucene-solr-pull-request-Fixing-typo-in-example-schema-salves-slaves-tp3760050p3761181.html
Sent from the Lucene - Java Developer mailing list archive at Nabble.com.

It's all part of an ongoing discussion about Git and GitHub at Apache. I don't know what the official ruling is on this stuff.

Fixing a typo - sure, just fix it.

Larger patches contributed this way? It's a little up in the air I think. But like I said - Apache seems to find that check box pretty important.

Practically, I think it's up to each committer to vet the code they are committing.

On Feb 20, 2012, at 11:21 AM, David Smiley (@MITRE.org) wrote:

> Ok, that's disappointing.  So much for ASF projects being part of the social coding revolution.  It's a big deal, by the way.  When people ask me what it's all about, I point them to this blob post by the Springframework team: http://blog.springsource.com/2010/12/21/social-coding-in-spring-projects/
> I suspect you are enlightened Mark but others reading our conversation might not be.
>
> So this guy's patch, the one I replied to, is a typo amounting to two characters.  Are there ASF guidelines on size of contributions?  Wether guidelines exist or not, IANAL but I believe there are practical considerations on the size of patches to not concern yourself with copyright.  I've seen estimates before ranging from 20-100 lines of code.
>
> ~ David
>
> On Feb 20, 2012, at 11:07 AM, Mark Miller-3 [via Lucene] wrote:
>
>> I think the problem is around the ASF's thoughts on what it means to contribute a patch in JIRA and click the check box about donating. They seem to find that important, and you don't have the same mechanism when grabbing pull requests from github.
>>
>> On Feb 20, 2012, at 10:56 AM, David Smiley (@MITRE.org) wrote:
>>
>> > Cool; pull-requests via GitHub.  Has anyone reacted to one of these messages
>> > and applied the change before?  If so what was the process?  Since
>> > lucene-solr is a mirror, is it impossible?
>> >
>> > ~ David
>> >
>> > -----
>> > Author: http://www.packtpub.com/apache-solr-3-enterprise-search-server/book
>> > --
>> > View this message in context: http://lucene.472066.n3.nabble.com/lucene-solr-pull-request-Fixing-typo-in-example-schema-salves-slaves-tp3760050p3761098.html
>> > Sent from the Lucene - Java Developer mailing list archive at Nabble.com.
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: <a href="x-msg://101/user/SendEmail.jtp?type=node&node=3761133&i=0" target="_top" rel="nofollow" link="external"> [hidden email]
>> > For additional commands, e-mail: <a href="x-msg://101/user/SendEmail.jtp?type=node&node=3761133&i=1" target="_top" rel="nofollow" link="external"> [hidden email]
>> >
>>
>> - Mark Miller
>> lucidimagination.com
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: <a href="x-msg://101/user/SendEmail.jtp?type=node&node=3761133&i=2" target="_top" rel="nofollow" link="external"> [hidden email]
>> For additional commands, e-mail: <a href="x-msg://101/user/SendEmail.jtp?type=node&node=3761133&i=3" target="_top" rel="nofollow" link="external"> [hidden email]
>>
>>
>>
>> If you reply to this email, your message will be added to the discussion below:
>> http://lucene.472066.n3.nabble.com/lucene-solr-pull-request-Fixing-typo-in-example-schema-salves-slaves-tp3760050p3761133.html
>> To unsubscribe from lucene-solr pull request: Fixing typo in example schema: 'salves' => 'slaves', click here.
>> NAML
>
>  Author: http://www.packtpub.com/apache-solr-3-enterprise-search-server/book
>
> View this message in context: Re: lucene-solr pull request: Fixing typo in example schema: 'salves' => 'slaves'
> Sent from the Lucene - Java Developer mailing list archive at Nabble.com.

- Mark Miller
lucidimagination.com


---------------------------------------------------------------------

I did notice that according to the post you linked to, Spring also
requires an additional step beyond a pull-request to document license
compliance:

-------------------------------------------------------------------------

I skirted over this in the article, but it's an important point. In
general, I'd like to see release change management be built right into
the contribution process. The same goes for Contributor License
Agreement (CLA) processing. I do not think we should be sending
contributors to three different places (e.g. Github to submit a pull
request, JIRA to create a issue containing duplicate information, and
springsource.org to sign the CLA). It should be one integrated,
streamlined process with no duplication.

It's my understanding Github has some nice hooks for customization, and
we should look into those. For the time being, the project teams will
need to manually ensure changes applied from pull requests get tracked
with the release(s) they are included in. In addition, project teams
will need to verify each contributor has signed a CLA to ensure all code
contributions are clean from a licensing perspective.

-------------------------------------------------------------------------

On 2/20/2012 11:21 AM, David Smiley (@MITRE.org) wrote:
> Ok, that's disappointing.  So much for ASF projects being part of the
> social coding revolution.  It's a big deal, by the way.  When people
> ask me what it's all about, I point them to this blob post by the
> Springframework team:
> http://blog.springsource.com/2010/12/21/social-coding-in-spring-projects/
> I suspect you are enlightened Mark but others reading our conversation
> might not be.
>
> So this guy's patch, the one I replied to, is a typo amounting to two
> characters.  Are there ASF guidelines on size of contributions?
>  Wether guidelines exist or not, IANAL but I believe there are
> practical considerations on the size of patches to not concern
> yourself with copyright.  I've seen estimates before ranging from
> 20-100 lines of code.
>
> ~ David
>
> On Feb 20, 2012, at 11:07 AM, Mark Miller-3 [via Lucene] wrote:
>
>> I think the problem is around the ASF's thoughts on what it means to
>> contribute a patch in JIRA and click the check box about donating.
>> They seem to find that important, and you don't have the same
>> mechanism when grabbing pull requests from github.
>>
>> On Feb 20, 2012, at 10:56 AM, David Smiley (@MITRE.org) wrote:
>>
>> > Cool; pull-requests via GitHub.  Has anyone reacted to one of these
>> messages
>> > and applied the change before?  If so what was the process?  Since
>> > lucene-solr is a mirror, is it impossible?
>> >
>> > ~ David
>> >
>> > -----
>> > Author:
>> http://www.packtpub.com/apache-solr-3-enterprise-search-server/book
>> > --
>> > View this message in context:
>> http://lucene.472066.n3.nabble.com/lucene-solr-pull-request-Fixing-typo-in-example-schema-salves-slaves-tp3760050p3761098.html
>> > Sent from the Lucene - Java Developer mailing list archive at
>> Nabble.com <http://Nabble.com>.
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: <a
>> href="x-msg://101/user/SendEmail.jtp?type=node&node=3761133&i=0"
>> target="_top" rel="nofollow" link="external"> [hidden email]
>> > For additional commands, e-mail: <a
>> href="x-msg://101/user/SendEmail.jtp?type=node&node=3761133&i=1"
>> target="_top" rel="nofollow" link="external"> [hidden email]
>> >
>>
>> - Mark Miller
>> lucidimagination.com <http://lucidimagination.com>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: <a
>> href="x-msg://101/user/SendEmail.jtp?type=node&node=3761133&i=2"
>> target="_top" rel="nofollow" link="external"> [hidden email]
>> For additional commands, e-mail: <a
>> href="x-msg://101/user/SendEmail.jtp?type=node&node=3761133&i=3"
>> target="_top" rel="nofollow" link="external"> [hidden email]

On Mon, Feb 20, 2012 at 11:07:05AM -0500, Mark Miller wrote:
> I think the problem is around the ASF's thoughts on what it means to
> contribute a patch in JIRA and click the check box about donating. They seem
> to find that important, and you don't have the same mechanism when grabbing
> pull requests from github.

The checkbox is not mandatory.  What is required is archived documentation of
clear intent on the part of the contributor to contribute on our terms, which
can take numerous forms.

    http://s.apache.org/roy-on-contributions-and-git

    Apache projects are not required to use Jira.  Contributions can
    be contributed using any of our communication forums and they are
    considered to be under the Apache License 2.0.

    ...

    Yes, that opinion comes from me speaking as a board member and
    author of the Apache License, and has previously been cleared
    with Apache's legal team for a long ago discussion with Incubator.
    
    ...

    We have archives on all of our communication channels. We don't need the
    silly checkbox. We never have.

The requirement that the documentation of the contributor's intent must reside
within archived channels controlled by the ASF poses challenges when
attempting to integrate with a self-contained external hosting platform such
as Github.  As that long thread on infrastructure-dev illustrates, though,
there is significant effort being expended to try to help us to work together.

Marvin Humphrey
---------------------------------------------------------------------

GitHub user JackDanger synchronized the pull request at
https://github.com/apache/lucene-solr/pull/2

----
Fixing typo in example schema: 'salves' => 'slaves'

Just a typo in a comment. Safe to merge.
----

You can merge this pull request into a Git repository by running
$ git pull https://github.com/JackDanger/lucene-solr patch-1

Alternatively you can review and apply these changes as the patch at
https://github.com/apache/lucene-solr/pull/2.patch

---------------------------------------------------------------------