Re-send, this time to pylucene-dev:

Everything looks good -- I was able to compile, run all tests
successfully, and run my usual smoke test (indexing & optimizing &
searching on first 100K wikipedia docs), but...

I then tried to enable the grouping module (lucene/contrib/grouping),
by adding a GROUPING_JAR matching all the other contrib jars, and
running "make".  This then hit various compilation errors -- is anyone
able to enable the grouping module and compile successfully?

Mike McCandless

http://blog.mikemccandless.com

On Sun, Jul 3, 2011 at 10:14 AM, Michael McCandless
<[EMAIL PROTECTED]> wrote:
> Everything looks good -- I was able to compile, run all tests
> successfully, and run my usual smoke test (indexing & optimizing &
> searching on first 100K wikipedia docs), but...
>
> I then tried to enable the grouping module (lucene/contrib/grouping),
> by adding a GROUPING_JAR matching all the other contrib jars, and
> running "make".  This then hit various compilation errors -- is anyone
> able to enable the grouping module and compile successfully?
>
> Mike McCandless
>
> http://blog.mikemccandless.com
>
> On Fri, Jul 1, 2011 at 8:24 AM, Andi Vajda <[EMAIL PROTECTED]> wrote:
>>
>> The PyLucene 3.3.0-1 release closely tracking the recent release of Lucene
>> Java 3.3 is ready.
>>
>> A release candidate is available from:
>> http://people.apache.org/~vajda/staging_area/
>>
>> A list of changes in this release can be seen at:
>> http://svn.apache.org/repos/asf/lucene/pylucene/branches/pylucene_3_3/CHANGES
>>
>> PyLucene 3.3.0 is built with JCC 2.9 included in these release artifacts.
>>
>> A list of Lucene Java changes can be seen at:
>> http://svn.apache.org/repos/asf/lucene/dev/tags/lucene_solr_3_3/lucene/CHANGES.txt
>>
>> Please vote to release these artifacts as PyLucene 3.3.0-1.
>>
>> Thanks !
>>
>> Andi..
>>
>> ps: the KEYS file for PyLucene release signing is at:
>> http://svn.apache.org/repos/asf/lucene/pylucene/dist/KEYS
>> http://people.apache.org/~vajda/staging_area/KEYS
>>
>> pps: here is my +1
>>
>

  Hi Mike,

On Sun, 3 Jul 2011, Michael McCandless wrote:

> Re-send, this time to pylucene-dev:
>
> Everything looks good -- I was able to compile, run all tests
> successfully, and run my usual smoke test (indexing & optimizing &
> searching on first 100K wikipedia docs), but...
>
> I then tried to enable the grouping module (lucene/contrib/grouping),
> by adding a GROUPING_JAR matching all the other contrib jars, and
> running "make".  This then hit various compilation errors -- is anyone
> able to enable the grouping module and compile successfully?

What kind of errors ?

So I added the grouping module to the PyLucene branch_3x build and it "just
built" (tm). I even committed the change to the build (rev 1142455) but I
didn't check that the grouping module was functional in PyLucene as I didn't
port any unit tests or even know much about it.

Andi..

>
> Mike McCandless
>
> http://blog.mikemccandless.com
>
> On Sun, Jul 3, 2011 at 10:14 AM, Michael McCandless
> <[EMAIL PROTECTED]> wrote:
>> Everything looks good -- I was able to compile, run all tests
>> successfully, and run my usual smoke test (indexing & optimizing &
>> searching on first 100K wikipedia docs), but...
>>
>> I then tried to enable the grouping module (lucene/contrib/grouping),
>> by adding a GROUPING_JAR matching all the other contrib jars, and
>> running "make". �This then hit various compilation errors -- is anyone
>> able to enable the grouping module and compile successfully?
>>
>> Mike McCandless
>>
>> http://blog.mikemccandless.com
>>
>> On Fri, Jul 1, 2011 at 8:24 AM, Andi Vajda <[EMAIL PROTECTED]> wrote:
>>>
>>> The PyLucene 3.3.0-1 release closely tracking the recent release of Lucene
>>> Java 3.3 is ready.
>>>
>>> A release candidate is available from:
>>> http://people.apache.org/~vajda/staging_area/
>>>
>>> A list of changes in this release can be seen at:
>>> http://svn.apache.org/repos/asf/lucene/pylucene/branches/pylucene_3_3/CHANGES
>>>
>>> PyLucene 3.3.0 is built with JCC 2.9 included in these release artifacts.
>>>
>>> A list of Lucene Java changes can be seen at:
>>> http://svn.apache.org/repos/asf/lucene/dev/tags/lucene_solr_3_3/lucene/CHANGES.txt
>>>
>>> Please vote to release these artifacts as PyLucene 3.3.0-1.
>>>
>>> Thanks !
>>>
>>> Andi..
>>>
>>> ps: the KEYS file for PyLucene release signing is at:
>>> http://svn.apache.org/repos/asf/lucene/pylucene/dist/KEYS
>>> http://people.apache.org/~vajda/staging_area/KEYS
>>>
>>> pps: here is my +1
>>>
>>
>

Am 03.07.2011 18:17, schrieb Andi Vajda:
> What kind of errors ?
>
> So I added the grouping module to the PyLucene branch_3x build and it "just
> built" (tm). I even committed the change to the build (rev 1142455) but I
> didn't check that the grouping module was functional in PyLucene as I didn't
> port any unit tests or even know much about it.

I'm getting an error on my box, too.

In file included from build/_lucene/__wrap01__.cpp:39469:0:
build/_lucene/org/apache/lucene/search/grouping/AbstractSecondPassGroupingCollector$SearchGroupDocs.h:55:83:
error: �AbstractSecondPassGroupingCollector� in namespace
�org::apache::lucene::search::grouping� does not name a type
build/_lucene/org/apache/lucene/search/grouping/AbstractSecondPassGroupingCollector$SearchGroupDocs.h:55:160:
error: ISO C++ forbids declaration of �parameter� with no type
build/_lucene/__wrap01__.cpp:39503:132: error:
�AbstractSecondPassGroupingCollector� in namespace
�org::apache::lucene::search::grouping� does not name a type
build/_lucene/__wrap01__.cpp:39503:211: error: ISO C++ forbids
declaration of �a0� with no type
build/_lucene/__wrap01__.cpp: In constructor
�org::apache::lucene::search::grouping::AbstractSecondPassGroupingCollector$SearchGroupDocs::AbstractSecondPassGroupingCollector$SearchGroupDocs(const
int&, const java::lang::Object&, const
org::apache::lucene::search::TopDocsCollector&)�:
build/_lucene/__wrap01__.cpp:39503:394: error: request for member
�this$� in �a0�, which is of non-class type �const int�
build/_lucene/__wrap01__.cpp: In function �int
org::apache::lucene::search::grouping::t_AbstractSecondPassGroupingCollector$SearchGroupDocs_init_(org::apache::lucene::search::grouping::t_AbstractSecondPassGroupingCollector$SearchGroupDocs*,
PyObject*, PyObject*)�:
build/_lucene/__wrap01__.cpp:39608:25: error:
�AbstractSecondPassGroupingCollector� is not a member of
�org::apache::lucene::search::grouping�
build/_lucene/__wrap01__.cpp:39608:102: error: expected �;� before �a0�
build/_lucene/__wrap01__.cpp:39615:30: error:
�org::apache::lucene::search::grouping::AbstractSecondPassGroupingCollector�
has not been declared
build/_lucene/__wrap01__.cpp:39615:30: error: �a0� was not declared in
this scope
build/_lucene/__wrap01__.cpp:39615:30: error:
�org::apache::lucene::search::grouping::t_AbstractSecondPassGroupingCollector�
has not been declared
error: command 'gcc' failed with exit status 1

Ubuntu 11.04 x86_64
GCC 4.5.2
Python 2.7.2

Christian

On Sun, 3 Jul 2011, Christian Heimes wrote:

> Am 03.07.2011 18:17, schrieb Andi Vajda:
>> What kind of errors ?
>>
>> So I added the grouping module to the PyLucene branch_3x build and it "just
>> built" (tm). I even committed the change to the build (rev 1142455) but I
>> didn't check that the grouping module was functional in PyLucene as I didn't
>> port any unit tests or even know much about it.
>
> I'm getting an error on my box, too.

While I don't see the error, I see that there could be something missing in
that header file, AbstractSecondPassGroupingCollector$SearchGroupDocs.h.
For example, TopDocsCollector is forward-declared there but
AbstractSecondPassGroupingCollector is not, even though it is used. What's
special about it is that it's the outer class of the class being defined
here, AbstractSecondPassGroupingCollector$SearchGroupDocs.

The reason I'm not seeing there error could be a difference in file
inclusion order somewhere getting this missing class definition included
from somewhere else.

I'm about to go on vacation for two weeks, without a computer (ok, email
only) and I should investigate this upon my return.

Still, that shouldn't necessarily block the PyLucene 3.3 release.
I'm fine with either solution, block the release on this or fix that for
3.4. Either way, I can't finish the release process until I return as the
vote has to run for three business days, ie, until Tuesday.

I'll leave it up to the voters to decide :-)

Andi..

>
> In file included from build/_lucene/__wrap01__.cpp:39469:0:
> build/_lucene/org/apache/lucene/search/grouping/AbstractSecondPassGroupingCollector$SearchGroupDocs.h:55:83:
> error: ?AbstractSecondPassGroupingCollector? in namespace
> ?org::apache::lucene::search::grouping? does not name a type
> build/_lucene/org/apache/lucene/search/grouping/AbstractSecondPassGroupingCollector$SearchGroupDocs.h:55:160:
> error: ISO C++ forbids declaration of ?parameter? with no type
> build/_lucene/__wrap01__.cpp:39503:132: error:
> ?AbstractSecondPassGroupingCollector? in namespace
> ?org::apache::lucene::search::grouping? does not name a type
> build/_lucene/__wrap01__.cpp:39503:211: error: ISO C++ forbids
> declaration of ?a0? with no type
> build/_lucene/__wrap01__.cpp: In constructor
> ?org::apache::lucene::search::grouping::AbstractSecondPassGroupingCollector$SearchGroupDocs::AbstractSecondPassGroupingCollector$SearchGroupDocs(const
> int&, const java::lang::Object&, const
> org::apache::lucene::search::TopDocsCollector&)?:
> build/_lucene/__wrap01__.cpp:39503:394: error: request for member
> ?this$? in ?a0?, which is of non-class type ?const int?
> build/_lucene/__wrap01__.cpp: In function ?int
> org::apache::lucene::search::grouping::t_AbstractSecondPassGroupingCollector$SearchGroupDocs_init_(org::apache::lucene::search::grouping::t_AbstractSecondPassGroupingCollector$SearchGroupDocs*,
> PyObject*, PyObject*)?:
> build/_lucene/__wrap01__.cpp:39608:25: error:
> ?AbstractSecondPassGroupingCollector? is not a member of
> ?org::apache::lucene::search::grouping?
> build/_lucene/__wrap01__.cpp:39608:102: error: expected ?;? before ?a0?
> build/_lucene/__wrap01__.cpp:39615:30: error:
> ?org::apache::lucene::search::grouping::AbstractSecondPassGroupingCollector?
> has not been declared
> build/_lucene/__wrap01__.cpp:39615:30: error: ?a0? was not declared in
> this scope
> build/_lucene/__wrap01__.cpp:39615:30: error:
> ?org::apache::lucene::search::grouping::t_AbstractSecondPassGroupingCollector?
> has not been declared
> error: command 'gcc' failed with exit status 1
>
> Ubuntu 11.04 x86_64
> GCC 4.5.2
> Python 2.7.2
>
> Christian
>

I agree this is not a release blocker -- +1 to release PyLucene 3.3.0-1.

Mike McCandless

http://blog.mikemccandless.com

On Sun, Jul 3, 2011 at 1:20 PM, Andi Vajda <[EMAIL PROTECTED]> wrote:
>
> On Sun, 3 Jul 2011, Christian Heimes wrote:
>
>> Am 03.07.2011 18:17, schrieb Andi Vajda:
>>>
>>> What kind of errors ?
>>>
>>> So I added the grouping module to the PyLucene branch_3x build and it
>>> "just
>>> built" (tm). I even committed the change to the build (rev 1142455) but I
>>> didn't check that the grouping module was functional in PyLucene as I
>>> didn't
>>> port any unit tests or even know much about it.
>>
>> I'm getting an error on my box, too.
>
> While I don't see the error, I see that there could be something missing in
> that header file, AbstractSecondPassGroupingCollector$SearchGroupDocs.h.
> For example, TopDocsCollector is forward-declared there but
> AbstractSecondPassGroupingCollector is not, even though it is used. What's
> special about it is that it's the outer class of the class being defined
> here, AbstractSecondPassGroupingCollector$SearchGroupDocs.
>
> The reason I'm not seeing there error could be a difference in file
> inclusion order somewhere getting this missing class definition included
> from somewhere else.
>
> I'm about to go on vacation for two weeks, without a computer (ok, email
> only) and I should investigate this upon my return.
>
> Still, that shouldn't necessarily block the PyLucene 3.3 release.
> I'm fine with either solution, block the release on this or fix that for
> 3.4. Either way, I can't finish the release process until I return as the
> vote has to run for three business days, ie, until Tuesday.
>
> I'll leave it up to the voters to decide :-)
>
> Andi..
>
>>
>> In file included from build/_lucene/__wrap01__.cpp:39469:0:
>>
>> build/_lucene/org/apache/lucene/search/grouping/AbstractSecondPassGroupingCollector$SearchGroupDocs.h:55:83:
>> error: ?AbstractSecondPassGroupingCollector? in namespace
>> ?org::apache::lucene::search::grouping? does not name a type
>>
>> build/_lucene/org/apache/lucene/search/grouping/AbstractSecondPassGroupingCollector$SearchGroupDocs.h:55:160:
>> error: ISO C++ forbids declaration of ?parameter? with no type
>> build/_lucene/__wrap01__.cpp:39503:132: error:
>> ?AbstractSecondPassGroupingCollector? in namespace
>> ?org::apache::lucene::search::grouping? does not name a type
>> build/_lucene/__wrap01__.cpp:39503:211: error: ISO C++ forbids
>> declaration of ?a0? with no type
>> build/_lucene/__wrap01__.cpp: In constructor
>>
>> ?org::apache::lucene::search::grouping::AbstractSecondPassGroupingCollector$SearchGroupDocs::AbstractSecondPassGroupingCollector$SearchGroupDocs(const
>> int&, const java::lang::Object&, const
>> org::apache::lucene::search::TopDocsCollector&)?:
>> build/_lucene/__wrap01__.cpp:39503:394: error: request for member
>> ?this$? in ?a0?, which is of non-class type ?const int?
>> build/_lucene/__wrap01__.cpp: In function ?int
>>
>> org::apache::lucene::search::grouping::t_AbstractSecondPassGroupingCollector$SearchGroupDocs_init_(org::apache::lucene::search::grouping::t_AbstractSecondPassGroupingCollector$SearchGroupDocs*,
>> PyObject*, PyObject*)?:
>> build/_lucene/__wrap01__.cpp:39608:25: error:
>> ?AbstractSecondPassGroupingCollector? is not a member of
>> ?org::apache::lucene::search::grouping?
>> build/_lucene/__wrap01__.cpp:39608:102: error: expected ?;? before ?a0?
>> build/_lucene/__wrap01__.cpp:39615:30: error:
>>
>> ?org::apache::lucene::search::grouping::AbstractSecondPassGroupingCollector?
>> has not been declared
>> build/_lucene/__wrap01__.cpp:39615:30: error: ?a0? was not declared in
>> this scope
>> build/_lucene/__wrap01__.cpp:39615:30: error:
>>
>> ?org::apache::lucene::search::grouping::t_AbstractSecondPassGroupingCollector?
>> has not been declared
>> error: command 'gcc' failed with exit status 1
>>
>> Ubuntu 11.04 x86_64
>> GCC 4.5.2
>> Python 2.7.2
>>
>> Christian
>>
>

On Sun, 3 Jul 2011, Christian Heimes wrote:

> Am 03.07.2011 18:17, schrieb Andi Vajda:
>> What kind of errors ?
>>
>> So I added the grouping module to the PyLucene branch_3x build and it "just
>> built" (tm). I even committed the change to the build (rev 1142455) but I
>> didn't check that the grouping module was functional in PyLucene as I didn't
>> port any unit tests or even know much about it.
>
> I'm getting an error on my box, too.

I fixed a bug with what looks like strange behaviour of the
java.lang.reflect.Constructor class: for a non-static inner class, it
appears that Constructor.getGenericParameterTypes() is not returning the
implicit first parameter - the instance of the declaring outer class - that
Constructor.getParameterTypes() is returning.
This difference is not documented (nor is the implicit first parameter
returned by the non-generic version).

Could you please get the latest jcc from trunk/branch_3x (version 2.10) and
verify that my fix really fixes it. I was able to reproduce and explain the
bug but would like to be sure I'm not missing something.

I re-enabled the grouping module on branch_3x.
Once verified, I'll spin a new PyLucene 3.3 release candidate as the
previous didn't garner the 3 required PMC votes anyway.

Thanks !

Andi..

>
> In file included from build/_lucene/__wrap01__.cpp:39469:0:
> build/_lucene/org/apache/lucene/search/grouping/AbstractSecondPassGroupingCollector$SearchGroupDocs.h:55:83:
> error: ?AbstractSecondPassGroupingCollector? in namespace
> ?org::apache::lucene::search::grouping? does not name a type
> build/_lucene/org/apache/lucene/search/grouping/AbstractSecondPassGroupingCollector$SearchGroupDocs.h:55:160:
> error: ISO C++ forbids declaration of ?parameter? with no type
> build/_lucene/__wrap01__.cpp:39503:132: error:
> ?AbstractSecondPassGroupingCollector? in namespace
> ?org::apache::lucene::search::grouping? does not name a type
> build/_lucene/__wrap01__.cpp:39503:211: error: ISO C++ forbids
> declaration of ?a0? with no type
> build/_lucene/__wrap01__.cpp: In constructor
> ?org::apache::lucene::search::grouping::AbstractSecondPassGroupingCollector$SearchGroupDocs::AbstractSecondPassGroupingCollector$SearchGroupDocs(const
> int&, const java::lang::Object&, const
> org::apache::lucene::search::TopDocsCollector&)?:
> build/_lucene/__wrap01__.cpp:39503:394: error: request for member
> ?this$? in ?a0?, which is of non-class type ?const int?
> build/_lucene/__wrap01__.cpp: In function ?int
> org::apache::lucene::search::grouping::t_AbstractSecondPassGroupingCollector$SearchGroupDocs_init_(org::apache::lucene::search::grouping::t_AbstractSecondPassGroupingCollector$SearchGroupDocs*,
> PyObject*, PyObject*)?:
> build/_lucene/__wrap01__.cpp:39608:25: error:
> ?AbstractSecondPassGroupingCollector? is not a member of
> ?org::apache::lucene::search::grouping?
> build/_lucene/__wrap01__.cpp:39608:102: error: expected ?;? before ?a0?
> build/_lucene/__wrap01__.cpp:39615:30: error:
> ?org::apache::lucene::search::grouping::AbstractSecondPassGroupingCollector?
> has not been declared
> build/_lucene/__wrap01__.cpp:39615:30: error: ?a0? was not declared in
> this scope
> build/_lucene/__wrap01__.cpp:39615:30: error:
> ?org::apache::lucene::search::grouping::t_AbstractSecondPassGroupingCollector?
> has not been declared
> error: command 'gcc' failed with exit status 1
>
> Ubuntu 11.04 x86_64
> GCC 4.5.2
> Python 2.7.2
>
> Christian
>

Sorry, I should have included my errors 1st time around:

In file included from build/_lucene/__wrap03__.cpp:514:
build/_lucene/org/apache/lucene/search/grouping/AbstractSecondPassGroupingCollector$SearchGroupDocs.h:55:
error: expected unqualified-id before '&' token
build/_lucene/org/apache/lucene/search/grouping/AbstractSecondPassGroupingCollector$SearchGroupDocs.h:55:
error: expected ',' or '...' before '&' token
build/_lucene/__wrap03__.cpp:548: error: expected unqualified-id
before '&' token
build/_lucene/__wrap03__.cpp:548: error: expected ',' or '...' before '&' token
build/_lucene/__wrap03__.cpp: In constructor
'org::apache::lucene::search::grouping::AbstractSecondPassGroupingCollector$SearchGroupDocs::AbstractSecondPassGroupingCollector$SearchGroupDocs()':
build/_lucene/__wrap03__.cpp:548: error: 'a0' was not declared in this scope
build/_lucene/__wrap03__.cpp:548: error: 'a1' was not declared in this scope
build/_lucene/__wrap03__.cpp:548: error: 'a2' was not declared in this scope
build/_lucene/__wrap03__.cpp: In function 'int
org::apache::lucene::search::grouping::t_AbstractSecondPassGroupingCollector$SearchGroupDocs_init_(org::apache::lucene::search::grouping::t_AbstractSecondPassGroupingCollector$SearchGroupDocs*,
PyObject*, PyObject*)':
build/_lucene/__wrap03__.cpp:653: error:
'AbstractSecondPassGroupingCollector' is not a member of
'org::apache::lucene::search::grouping'
build/_lucene/__wrap03__.cpp:653: error: expected `;' before 'a0'
build/_lucene/__wrap03__.cpp:660: error:
'org::apache::lucene::search::grouping::AbstractSecondPassGroupingCollector'
has not been declared
build/_lucene/__wrap03__.cpp:660: error: 'a0' was not declared in this scope
build/_lucene/__wrap03__.cpp:660: error:
'org::apache::lucene::search::grouping::t_AbstractSecondPassGroupingCollector'
has not been declared
error: command 'gcc-4.2' failed with exit status 1
make: *** [compile] Error 1

My env is OS X 10.6.6, Apple's build of Python (2.6.1), Java 1.6.0_22.

Mike McCandless

http://blog.mikemccandless.com

On Sun, Jul 3, 2011 at 12:17 PM, Andi Vajda <[EMAIL PROTECTED]> wrote:
>
>  Hi Mike,
>
> On Sun, 3 Jul 2011, Michael McCandless wrote:
>
>> Re-send, this time to pylucene-dev:
>>
>> Everything looks good -- I was able to compile, run all tests
>> successfully, and run my usual smoke test (indexing & optimizing &
>> searching on first 100K wikipedia docs), but...
>>
>> I then tried to enable the grouping module (lucene/contrib/grouping),
>> by adding a GROUPING_JAR matching all the other contrib jars, and
>> running "make".  This then hit various compilation errors -- is anyone
>> able to enable the grouping module and compile successfully?
>
> What kind of errors ?
>
> So I added the grouping module to the PyLucene branch_3x build and it "just
> built" (tm). I even committed the change to the build (rev 1142455) but I
> didn't check that the grouping module was functional in PyLucene as I didn't
> port any unit tests or even know much about it.
>
> Andi..
>
>>
>> Mike McCandless
>>
>> http://blog.mikemccandless.com
>>
>> On Sun, Jul 3, 2011 at 10:14 AM, Michael McCandless
>> <[EMAIL PROTECTED]> wrote:
>>>
>>> Everything looks good -- I was able to compile, run all tests
>>> successfully, and run my usual smoke test (indexing & optimizing &
>>> searching on first 100K wikipedia docs), but...
>>>
>>> I then tried to enable the grouping module (lucene/contrib/grouping),
>>> by adding a GROUPING_JAR matching all the other contrib jars, and
>>> running "make".  This then hit various compilation errors -- is anyone
>>> able to enable the grouping module and compile successfully?
>>>
>>> Mike McCandless
>>>
>>> http://blog.mikemccandless.com
>>>
>>> On Fri, Jul 1, 2011 at 8:24 AM, Andi Vajda <[EMAIL PROTECTED]> wrote:
>>>>
>>>> The PyLucene 3.3.0-1 release closely tracking the recent release of
>>>> Lucene
>>>> Java 3.3 is ready.
>>>>
>>>> A release candidate is available from:
>>>> http://people.apache.org/~vajda/staging_area/
>>>

Am 01.07.2011 14:24, schrieb Andi Vajda:
>
> The PyLucene 3.3.0-1 release closely tracking the recent release of Lucene
> Java 3.3 is ready.
>
> A release candidate is available from:
> http://people.apache.org/~vajda/staging_area/
>
> A list of changes in this release can be seen at:
> http://svn.apache.org/repos/asf/lucene/pylucene/branches/pylucene_3_3/CHANGES
>
> PyLucene 3.3.0 is built with JCC 2.9 included in these release artifacts.
>
> A list of Lucene Java changes can be seen at:
> http://svn.apache.org/repos/asf/lucene/dev/tags/lucene_solr_3_3/lucene/CHANGES.txt
>
> Please vote to release these artifacts as PyLucene 3.3.0-1.

I've tested PyLucene 3.3 with your application, everything still works.
I can't comment on new features, though.

+1 from me

By the way could you please keep a consistent version schema? You are
slowly dropping the zero at the end. ;)

pylucene-3.1.0-1-src.tar.gz   LUCENE_VER=3.1.0
pylucene-3.2.0-1-src.tar.gz   LUCENE_VER=3.2
pylucene-3.3-1-src.tar.gz     LUCENE_VER=3.3

Christian

On Jul 2, 2011, at 13:58, Christian Heimes <[EMAIL PROTECTED]> wrote:

> Am 01.07.2011 14:24, schrieb Andi Vajda:
>>
>> The PyLucene 3.3.0-1 release closely tracking the recent release of Lucene
>> Java 3.3 is ready.
>>
>> A release candidate is available from:
>> http://people.apache.org/~vajda/staging_area/
>>
>> A list of changes in this release can be seen at:
>> http://svn.apache.org/repos/asf/lucene/pylucene/branches/pylucene_3_3/CHANGES
>>
>> PyLucene 3.3.0 is built with JCC 2.9 included in these release artifacts.
>>
>> A list of Lucene Java changes can be seen at:
>> http://svn.apache.org/repos/asf/lucene/dev/tags/lucene_solr_3_3/lucene/CHANGES.txt
>>
>> Please vote to release these artifacts as PyLucene 3.3.0-1.
>
> I've tested PyLucene 3.3 with your application, everything still works.
> I can't comment on new features, though.
>
> +1 from me
>
> By the way could you please keep a consistent version schema? You are
> slowly dropping the zero at the end. ;)
>
> pylucene-3.1.0-1-src.tar.gz   LUCENE_VER=3.1.0
> pylucene-3.2.0-1-src.tar.gz   LUCENE_VER=3.2
> pylucene-3.3-1-src.tar.gz     LUCENE_VER=3.3

:-)
I resisted the Lucene Java 0 droppage but it got the best of me.

Andi..

>
> Christian

Without the third 0, how will you version critical patch releases should
they be necessary?

On 07/02/2011 09:13 AM, Andi Vajda wrote:
> On Jul 2, 2011, at 13:58, Christian Heimes<[EMAIL PROTECTED]>  wrote:
>
>> Am 01.07.2011 14:24, schrieb Andi Vajda:
>>> The PyLucene 3.3.0-1 release closely tracking the recent release of Lucene
>>> Java 3.3 is ready.
>>>
>>> A release candidate is available from:
>>> http://people.apache.org/~vajda/staging_area/
>>>
>>> A list of changes in this release can be seen at:
>>> http://svn.apache.org/repos/asf/lucene/pylucene/branches/pylucene_3_3/CHANGES
>>>
>>> PyLucene 3.3.0 is built with JCC 2.9 included in these release artifacts.
>>>
>>> A list of Lucene Java changes can be seen at:
>>> http://svn.apache.org/repos/asf/lucene/dev/tags/lucene_solr_3_3/lucene/CHANGES.txt
>>>
>>> Please vote to release these artifacts as PyLucene 3.3.0-1.
>> I've tested PyLucene 3.3 with your application, everything still works.
>> I can't comment on new features, though.
>>
>> +1 from me
>>
>> By the way could you please keep a consistent version schema? You are
>> slowly dropping the zero at the end. ;)
>>
>> pylucene-3.1.0-1-src.tar.gz   LUCENE_VER=3.1.0
>> pylucene-3.2.0-1-src.tar.gz   LUCENE_VER=3.2
>> pylucene-3.3-1-src.tar.gz     LUCENE_VER=3.3
> :-)
> I resisted the Lucene Java 0 droppage but it got the best of me.
>
> Andi..
>
>> Christian

On Jul 2, 2011, at 15:20, Darren Govoni <[EMAIL PROTECTED]> wrote:

> Without the third 0, how will you version critical patch releases should they be necessary?

If the patch comes from Lucene, then I'd use their new version number, as usual. If it's a PyLucene fix, its version would go from 3.3-1 to 3.3-2.

Andi..

>
> On 07/02/2011 09:13 AM, Andi Vajda wrote:
>> On Jul 2, 2011, at 13:58, Christian Heimes<[EMAIL PROTECTED]>  wrote:
>>
>>> Am 01.07.2011 14:24, schrieb Andi Vajda:
>>>> The PyLucene 3.3.0-1 release closely tracking the recent release of Lucene
>>>> Java 3.3 is ready.
>>>>
>>>> A release candidate is available from:
>>>> http://people.apache.org/~vajda/staging_area/
>>>>
>>>> A list of changes in this release can be seen at:
>>>> http://svn.apache.org/repos/asf/lucene/pylucene/branches/pylucene_3_3/CHANGES
>>>>
>>>> PyLucene 3.3.0 is built with JCC 2.9 included in these release artifacts.
>>>>
>>>> A list of Lucene Java changes can be seen at:
>>>> http://svn.apache.org/repos/asf/lucene/dev/tags/lucene_solr_3_3/lucene/CHANGES.txt
>>>>
>>>> Please vote to release these artifacts as PyLucene 3.3.0-1.
>>> I've tested PyLucene 3.3 with your application, everything still works.
>>> I can't comment on new features, though.
>>>
>>> +1 from me
>>>
>>> By the way could you please keep a consistent version schema? You are
>>> slowly dropping the zero at the end. ;)
>>>
>>> pylucene-3.1.0-1-src.tar.gz   LUCENE_VER=3.1.0
>>> pylucene-3.2.0-1-src.tar.gz   LUCENE_VER=3.2
>>> pylucene-3.3-1-src.tar.gz     LUCENE_VER=3.3
>> :-)
>> I resisted the Lucene Java 0 droppage but it got the best of me.
>>
>> Andi..
>>
>>> Christian