Hi

I wrote a TwoPhaseCommit interface which declares the methods necessary
to implement a 2-phase commit algorithm:
* prepareCommit()
* commit()
* rollback()

The prepare/commit ones have variants that take a (Map<String,String>
commitData) following the ones we have in IndexWriter.

I also wrote TwoPhaseCommitTool which implements a 2-phase
commit amongst several TPCs.

Both were written with the intention to use them while committing an
IndexWriter + objects that use IW internally. Making IW impl it will be
convenient.

Plus, I think it is a useful interface and perhaps we'll find other uses for

it in the future (maybe Solr already has?)

I know that interfaces are not very popular here, so I don't mind if we
mark it @lucene.internal.

What do you think? I can post a patch if you think this is worth having in
Lucene.

Shai

This sounds great!

Mike McCandless

http://blog.mikemccandless.com

On Sat, Jun 11, 2011 at 7:28 AM, Shai Erera <[EMAIL PROTECTED]> wrote:
> Hi
>
> I wrote a TwoPhaseCommit interface which declares the methods necessary
> to implement a 2-phase commit algorithm:
> * prepareCommit()
> * commit()
> * rollback()
>
> The prepare/commit ones have variants that take a (Map<String,String>
> commitData) following the ones we have in IndexWriter.
>
> I also wrote TwoPhaseCommitTool which implements a 2-phase
> commit amongst several TPCs.
>
> Both were written with the intention to use them while committing an
> IndexWriter + objects that use IW internally. Making IW impl it will be
> convenient.
>
> Plus, I think it is a useful interface and perhaps we'll find other uses for
> it in the future (maybe Solr already has?)
>
> I know that interfaces are not very popular here, so I don't mind if we
> mark it @lucene.internal.
>
> What do you think? I can post a patch if you think this is worth having in
> Lucene.
>
> Shai
>

---------------------------------------------------------------------

Thanks Mike. Opened LUCENE-3193.

Shai

On Sat, Jun 11, 2011 at 3:00 PM, Michael McCandless <
[EMAIL PROTECTED]> wrote:

> This sounds great!
>
> Mike McCandless
>
> http://blog.mikemccandless.com
>
> On Sat, Jun 11, 2011 at 7:28 AM, Shai Erera <[EMAIL PROTECTED]> wrote:
> > Hi
> >
> > I wrote a TwoPhaseCommit interface which declares the methods necessary
> > to implement a 2-phase commit algorithm:
> > * prepareCommit()
> > * commit()
> > * rollback()
> >
> > The prepare/commit ones have variants that take a (Map<String,String>
> > commitData) following the ones we have in IndexWriter.
> >
> > I also wrote TwoPhaseCommitTool which implements a 2-phase
> > commit amongst several TPCs.
> >
> > Both were written with the intention to use them while committing an
> > IndexWriter + objects that use IW internally. Making IW impl it will be
> > convenient.
> >
> > Plus, I think it is a useful interface and perhaps we'll find other uses
> for
> > it in the future (maybe Solr already has?)
> >
> > I know that interfaces are not very popular here, so I don't mind if we
> > mark it @lucene.internal.
> >
> > What do you think? I can post a patch if you think this is worth having
> in
> > Lucene.
> >
> > Shai
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>

On Sat, Jun 11, 2011 at 2:00 PM, Michael McCandless
<[EMAIL PROTECTED]> wrote:
> This sounds great!
>
+1
> Mike McCandless
>
> http://blog.mikemccandless.com
>
> On Sat, Jun 11, 2011 at 7:28 AM, Shai Erera <[EMAIL PROTECTED]> wrote:
>> Hi
>>
>> I wrote a TwoPhaseCommit interface which declares the methods necessary
>> to implement a 2-phase commit algorithm:
>> * prepareCommit()
>> * commit()
>> * rollback()
>>
>> The prepare/commit ones have variants that take a (Map<String,String>
>> commitData) following the ones we have in IndexWriter.
>>
>> I also wrote TwoPhaseCommitTool which implements a 2-phase
>> commit amongst several TPCs.
>>
>> Both were written with the intention to use them while committing an
>> IndexWriter + objects that use IW internally. Making IW impl it will be
>> convenient.
>>
>> Plus, I think it is a useful interface and perhaps we'll find other uses for
>> it in the future (maybe Solr already has?)
>>
>> I know that interfaces are not very popular here, so I don't mind if we
>> mark it @lucene.internal.
>>
>> What do you think? I can post a patch if you think this is worth having in
>> Lucene.
>>
>> Shai
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>

---------------------------------------------------------------------