|
|
-
Eclipse-Lucene-Codestyle.xml
Jeff Eastman 2012-04-18, 13:22
I just imported this file for use with Mahout and noticed it has 80 column limits for source files and comments. IIRC, we agreed to use 120 columns some time ago. When I use this file it does massive reformatting as a result. Does this file need to be updated?
Jeff
+
Jeff Eastman 2012-04-18, 13:22
-
Re: Eclipse-Lucene-Codestyle.xml
Ted Dunning 2012-04-18, 15:41
Yes. It needs updating.
Sent from my iPhone
On Apr 18, 2012, at 6:22 AM, Jeff Eastman <[EMAIL PROTECTED]> wrote:
> I just imported this file for use with Mahout and noticed it has 80 column limits for source files and comments. IIRC, we agreed to use 120 columns some time ago. When I use this file it does massive reformatting as a result. Does this file need to be updated? > > Jeff
+
Ted Dunning 2012-04-18, 15:41
-
Re: Eclipse-Lucene-Codestyle.xml
Lance Norskog 2012-04-19, 03:02
Also, make sure it does not reformat comments. A lot of comments are written with "text formatting" instead of html and the eclipse codestyle default word-wraps them.
On Wed, Apr 18, 2012 at 8:41 AM, Ted Dunning <[EMAIL PROTECTED]> wrote: > Yes. It needs updating. > > Sent from my iPhone > > On Apr 18, 2012, at 6:22 AM, Jeff Eastman <[EMAIL PROTECTED]> wrote: > >> I just imported this file for use with Mahout and noticed it has 80 column limits for source files and comments. IIRC, we agreed to use 120 columns some time ago. When I use this file it does massive reformatting as a result. Does this file need to be updated? >> >> Jeff
-- Lance Norskog [EMAIL PROTECTED]
+
Lance Norskog 2012-04-19, 03:02
-
Re: Eclipse-Lucene-Codestyle.xml
Jeff Eastman 2012-04-19, 14:34
I looked at the comment formatting, and some of the formatting (e.g. Javadoc comments) seems necessary. It may be necessary to turn off Line Comment formatting in my last commit. Can you check that out and see if you agree?
On 4/18/12 11:02 PM, Lance Norskog wrote: > Also, make sure it does not reformat comments. A lot of comments are > written with "text formatting" instead of html and the eclipse > codestyle default word-wraps them. > > On Wed, Apr 18, 2012 at 8:41 AM, Ted Dunning<[EMAIL PROTECTED]> wrote: >> Yes. It needs updating. >> >> Sent from my iPhone >> >> On Apr 18, 2012, at 6:22 AM, Jeff Eastman<[EMAIL PROTECTED]> wrote: >> >>> I just imported this file for use with Mahout and noticed it has 80 column limits for source files and comments. IIRC, we agreed to use 120 columns some time ago. When I use this file it does massive reformatting as a result. Does this file need to be updated? >>> >>> Jeff > >
+
Jeff Eastman 2012-04-19, 14:34
-
Re: Eclipse-Lucene-Codestyle.xml
Lance Norskog 2012-04-20, 01:55
I can't. Please change it so that it does not word-wrap comments. That's all I ask.
On Thu, Apr 19, 2012 at 7:34 AM, Jeff Eastman <[EMAIL PROTECTED]> wrote: > I looked at the comment formatting, and some of the formatting (e.g. Javadoc > comments) seems necessary. It may be necessary to turn off Line Comment > formatting in my last commit. Can you check that out and see if you agree? > > > On 4/18/12 11:02 PM, Lance Norskog wrote: >> >> Also, make sure it does not reformat comments. A lot of comments are >> written with "text formatting" instead of html and the eclipse >> codestyle default word-wraps them. >> >> On Wed, Apr 18, 2012 at 8:41 AM, Ted Dunning<[EMAIL PROTECTED]> >> wrote: >>> >>> Yes. It needs updating. >>> >>> Sent from my iPhone >>> >>> On Apr 18, 2012, at 6:22 AM, Jeff Eastman<[EMAIL PROTECTED]> >>> wrote: >>> >>>> I just imported this file for use with Mahout and noticed it has 80 >>>> column limits for source files and comments. IIRC, we agreed to use 120 >>>> columns some time ago. When I use this file it does massive reformatting as >>>> a result. Does this file need to be updated? >>>> >>>> Jeff >> >> >> >
-- Lance Norskog [EMAIL PROTECTED]
+
Lance Norskog 2012-04-20, 01:55
|
|