Hello-

Is raw-schema.jsp in use?  It isn't (nor has it been) linked to
anything.  The schema/config links used to point to get-file.jsp

Should we remove it?  Add a deprecation warning?

ryan

I don't think a deprecation warning is necessary (it's not really  
part of the "interface" of Solr).

-Mike

On 2-Jan-08, at 9:14 AM, Ryan McKinley wrote:

> Hello-
>
> Is raw-schema.jsp in use?  It isn't (nor has it been) linked to  
> anything.  The schema/config links used to point to get-file.jsp
>
> Should we remove it?  Add a deprecation warning?
>
> ryan

thats my feeling...  the more code we can remove from .jsp files, the
better.

SOLR-142 did add a deprecation warning to get-file.jsp -- but I think
that is reasonable to keep around since (i think) some people depend on
it to read the remote schema/config.

ryan
Mike Klaas wrote:
> I don't think a deprecation warning is necessary (it's not really part
> of the "interface" of Solr).
>
> -Mike
>
> On 2-Jan-08, at 9:14 AM, Ryan McKinley wrote:
>
>> Hello-
>>
>> Is raw-schema.jsp in use?  It isn't (nor has it been) linked to
>> anything.  The schema/config links used to point to get-file.jsp
>>
>> Should we remove it?  Add a deprecation warning?
>>
>> ryan
>
>

: Is raw-schema.jsp in use?  It isn't (nor has it been) linked to anything.  The
: schema/config links used to point to get-file.jsp

once upon a time it was used by the schema link on the admin screen ...
not sure when that changed, but there was never really much need for it
considering we've always had get-file.jsp.

: Should we remove it?  Add a deprecation warning?

the safest thing to do (with both this and get-files.jsp since i think i
saw a ShowFileRequestHandler has replaced it) would probably be to replace
the meat of those JSPs with something like...

   <%  log.warn("deprecated JSP URL used: " +
                request.getRequestURL().append("?").append
                   (request.getQueryString()));
   %><jsp:forward page=" ... " />
-Hoss

check rev 608613

added the file back and am using log.warning() for messages (not System.out)
Chris Hostetter wrote:
> : Is raw-schema.jsp in use?  It isn't (nor has it been) linked to anything.  The
> : schema/config links used to point to get-file.jsp
>
> once upon a time it was used by the schema link on the admin screen ...
> not sure when that changed, but there was never really much need for it
> considering we've always had get-file.jsp.
>
> : Should we remove it?  Add a deprecation warning?
>
> the safest thing to do (with both this and get-files.jsp since i think i
> saw a ShowFileRequestHandler has replaced it) would probably be to replace
> the meat of those JSPs with something like...
>
>    <%  log.warn("deprecated JSP URL used: " +
>                 request.getRequestURL().append("?").append
>                    (request.getQueryString()));
>    %><jsp:forward page=" ... " />
>
>
>
>
> -Hoss
>
>