Looks like this caused the tests to fail...
I've checked in a temporary fix: r1025794

-Yonik
http://www.lucidimagination.com

On Wed, Oct 20, 2010 at 6:28 PM,  <[EMAIL PROTECTED]> wrote:
> Author: ab
> Date: Wed Oct 20 22:28:52 2010
> New Revision: 1025784
>
> URL: http://svn.apache.org/viewvc?rev=1025784&view=rev
> Log:
> Threshold parameter is a float, not a string representation of a float.
>
> Modified:
>    lucene/dev/branches/branch_3x/solr/src/java/org/apache/solr/spelling/suggest/Suggester.java
>    lucene/dev/trunk/solr/src/java/org/apache/solr/spelling/suggest/Suggester.java
>
> Modified: lucene/dev/branches/branch_3x/solr/src/java/org/apache/solr/spelling/suggest/Suggester.java
> URL: http://svn.apache.org/viewvc/lucene/dev/branches/branch_3x/solr/src/java/org/apache/solr/spelling/suggest/Suggester.java?rev=1025784&r1=1025783&r2=1025784&view=diff
> =============================================================================> --- lucene/dev/branches/branch_3x/solr/src/java/org/apache/solr/spelling/suggest/Suggester.java (original)
> +++ lucene/dev/branches/branch_3x/solr/src/java/org/apache/solr/spelling/suggest/Suggester.java Wed Oct 20 22:28:52 2010
> @@ -77,7 +77,7 @@ public class Suggester extends SolrSpell
>     LOG.info("init: " + config);
>     String name = super.init(config, core);
>     threshold = config.get(THRESHOLD_TOKEN_FREQUENCY) == null ? 0.0f
> -            : Float.valueOf((String)config.get(THRESHOLD_TOKEN_FREQUENCY));
> +            : (Float)config.get(THRESHOLD_TOKEN_FREQUENCY);
>     sourceLocation = (String) config.get(LOCATION);
>     field = (String)config.get(FIELD);
>     lookupImpl = (String)config.get(LOOKUP_IMPL);
>
> Modified: lucene/dev/trunk/solr/src/java/org/apache/solr/spelling/suggest/Suggester.java
> URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/src/java/org/apache/solr/spelling/suggest/Suggester.java?rev=1025784&r1=1025783&r2=1025784&view=diff
> =============================================================================> --- lucene/dev/trunk/solr/src/java/org/apache/solr/spelling/suggest/Suggester.java (original)
> +++ lucene/dev/trunk/solr/src/java/org/apache/solr/spelling/suggest/Suggester.java Wed Oct 20 22:28:52 2010
> @@ -76,7 +76,7 @@ public class Suggester extends SolrSpell
>     LOG.info("init: " + config);
>     String name = super.init(config, core);
>     threshold = config.get(THRESHOLD_TOKEN_FREQUENCY) == null ? 0.0f
> -            : Float.valueOf((String)config.get(THRESHOLD_TOKEN_FREQUENCY));
> +            : (Float)config.get(THRESHOLD_TOKEN_FREQUENCY);
>     sourceLocation = (String) config.get(LOCATION);
>     field = (String)config.get(FIELD);
>     lookupImpl = (String)config.get(LOOKUP_IMPL);
>
>
>

---------------------------------------------------------------------

This is my fault in SOLR-2139. I'll revert the fix, and correct
str to float in solrconfig-spellchecker.xml.

Koji
--
http://www.rondhuit.com/en/

(10/10/21 8:50), Yonik Seeley wrote:
> Looks like this caused the tests to fail...
> I've checked in a temporary fix: r1025794
>
> -Yonik
> http://www.lucidimagination.com
>
>
>
> On Wed, Oct 20, 2010 at 6:28 PM,<[EMAIL PROTECTED]>  wrote:
>> Author: ab
>> Date: Wed Oct 20 22:28:52 2010
>> New Revision: 1025784
>>
>> URL: http://svn.apache.org/viewvc?rev=1025784&view=rev
>> Log:
>> Threshold parameter is a float, not a string representation of a float.
>>
>> Modified:
>>     lucene/dev/branches/branch_3x/solr/src/java/org/apache/solr/spelling/suggest/Suggester.java
>>     lucene/dev/trunk/solr/src/java/org/apache/solr/spelling/suggest/Suggester.java
>>
>> Modified: lucene/dev/branches/branch_3x/solr/src/java/org/apache/solr/spelling/suggest/Suggester.java
>> URL: http://svn.apache.org/viewvc/lucene/dev/branches/branch_3x/solr/src/java/org/apache/solr/spelling/suggest/Suggester.java?rev=1025784&r1=1025783&r2=1025784&view=diff
>> =============================================================================>> --- lucene/dev/branches/branch_3x/solr/src/java/org/apache/solr/spelling/suggest/Suggester.java (original)
>> +++ lucene/dev/branches/branch_3x/solr/src/java/org/apache/solr/spelling/suggest/Suggester.java Wed Oct 20 22:28:52 2010
>> @@ -77,7 +77,7 @@ public class Suggester extends SolrSpell
>>      LOG.info("init: " + config);
>>      String name = super.init(config, core);
>>      threshold = config.get(THRESHOLD_TOKEN_FREQUENCY) == null ? 0.0f
>> -            : Float.valueOf((String)config.get(THRESHOLD_TOKEN_FREQUENCY));
>> +            : (Float)config.get(THRESHOLD_TOKEN_FREQUENCY);
>>      sourceLocation = (String) config.get(LOCATION);
>>      field = (String)config.get(FIELD);
>>      lookupImpl = (String)config.get(LOOKUP_IMPL);
>>
>> Modified: lucene/dev/trunk/solr/src/java/org/apache/solr/spelling/suggest/Suggester.java
>> URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/src/java/org/apache/solr/spelling/suggest/Suggester.java?rev=1025784&r1=1025783&r2=1025784&view=diff
>> =============================================================================>> --- lucene/dev/trunk/solr/src/java/org/apache/solr/spelling/suggest/Suggester.java (original)
>> +++ lucene/dev/trunk/solr/src/java/org/apache/solr/spelling/suggest/Suggester.java Wed Oct 20 22:28:52 2010
>> @@ -76,7 +76,7 @@ public class Suggester extends SolrSpell
>>      LOG.info("init: " + config);
>>      String name = super.init(config, core);
>>      threshold = config.get(THRESHOLD_TOKEN_FREQUENCY) == null ? 0.0f
>> -            : Float.valueOf((String)config.get(THRESHOLD_TOKEN_FREQUENCY));
>> +            : (Float)config.get(THRESHOLD_TOKEN_FREQUENCY);
>>      sourceLocation = (String) config.get(LOCATION);
>>      field = (String)config.get(FIELD);
>>      lookupImpl = (String)config.get(LOOKUP_IMPL);
>>
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>
---------------------------------------------------------------------

On 2010-10-21 02:18, Koji Sekiguchi wrote:
> This is my fault in SOLR-2139. I'll revert the fix, and correct
> str to float in solrconfig-spellchecker.xml.

I'll take a partial responsibility for this too - I should have run all
tests, not just the SuggesterTest... Thanks for fixing it.

--
Best regards,
Andrzej Bialecki     <><
 ___. ___ ___ ___ _ _   __________________________________
[__ || __|__/|__||\/|  Information Retrieval, Semantic Web
___|||__||  \|  ||  |  Embedded Unix, System Integration
http://www.sigram.com  Contact: info at sigram dot com
---------------------------------------------------------------------