Hi all,

We encountered several bugs with the Sparial contrb, and the ones we tested
with Java Lucene worked there (with 2.9.4). There are about 3 open tickets
in the Jira bug tracker on similar issues.

I'm now sitting with the ultimate goal of fixing this once and for all, but
some code parts are commented out in favor of other not line-by-line port
of some implementations, without a comment giving reasons. I was wondering
if there's anyone who could answer a few questions there, instead of me
changing things back and forth?

Git history (I use the Git mirror, yes) tells me Prescott Nasser is behind
porting this - maybe he will have the answers?

Cheers,

Itamar.

I think that was a while ago, and I don't even recall if I fully ported it or just put up the start. I had some other stuff to deal with the last few months, so my memory is a bit lacking. I'll review the code, meanwhile ask whatever questions you have - lets get this fixed up. ~P
 > Date: Sun, 22 Apr 2012 22:10:27 +0300
> Subject: Spatial contrib bug fixing
> From: [EMAIL PROTECTED]
> To: [EMAIL PROTECTED]
>
> Hi all,
>
> We encountered several bugs with the Sparial contrb, and the ones we tested
> with Java Lucene worked there (with 2.9.4). There are about 3 open tickets
> in the Jira bug tracker on similar issues.
>
> I'm now sitting with the ultimate goal of fixing this once and for all, but
> some code parts are commented out in favor of other not line-by-line port
> of some implementations, without a comment giving reasons. I was wondering
> if there's anyone who could answer a few questions there, instead of me
> changing things back and forth?
>
> Git history (I use the Git mirror, yes) tells me Prescott Nasser is behind
> porting this - maybe he will have the answers?
>
> Cheers,
>
> Itamar.
     

For starters - CartesianPolyFilterBuilder.GetBoxShape() is not an exact
port - do you remember why?

Anyway, if it was never fully ported as you say maybe I'll just go ahead
and complete that

For your reference, here are 2 failing tests which pass in Java Lucene (can
send the java file) -
https://github.com/synhershko/lucene.net/commit/234da7eca7cb08be5a0c2a7375ffc3f4a03bfd92
On Mon, Apr 23, 2012 at 1:39 AM, Prescott Nasser <[EMAIL PROTECTED]>wrote:

>
> I think that was a while ago, and I don't even recall if I fully ported it
> or just put up the start. I had some other stuff to deal with the last few
> months, so my memory is a bit lacking. I'll review the code, meanwhile ask
> whatever questions you have - lets get this fixed up. ~P
>  > Date: Sun, 22 Apr 2012 22:10:27 +0300
> > Subject: Spatial contrib bug fixing
> > From: [EMAIL PROTECTED]
> > To: [EMAIL PROTECTED]
> >
> > Hi all,
> >
> > We encountered several bugs with the Sparial contrb, and the ones we
> tested
> > with Java Lucene worked there (with 2.9.4). There are about 3 open
> tickets
> > in the Jira bug tracker on similar issues.
> >
> > I'm now sitting with the ultimate goal of fixing this once and for all,
> but
> > some code parts are commented out in favor of other not line-by-line port
> > of some implementations, without a comment giving reasons. I was
> wondering
> > if there's anyone who could answer a few questions there, instead of me
> > changing things back and forth?
> >
> > Git history (I use the Git mirror, yes) tells me Prescott Nasser is
> behind
> > porting this - maybe he will have the answers?
> >
> > Cheers,
> >
> > Itamar.
>
>

One more thing - what's the deal with ChainedFilter? I can see a commit by
DIGY on 7/7/2011 but it seems to have been removed since?

On Mon, Apr 23, 2012 at 11:06 AM, Itamar Syn-Hershko <[EMAIL PROTECTED]>wrote:

> For starters - CartesianPolyFilterBuilder.GetBoxShape() is not an exact
> port - do you remember why?
>
> Anyway, if it was never fully ported as you say maybe I'll just go ahead
> and complete that
>
> For your reference, here are 2 failing tests which pass in Java Lucene
> (can send the java file) -
> https://github.com/synhershko/lucene.net/commit/234da7eca7cb08be5a0c2a7375ffc3f4a03bfd92
>
>
>
> On Mon, Apr 23, 2012 at 1:39 AM, Prescott Nasser <[EMAIL PROTECTED]>wrote:
>
>>
>> I think that was a while ago, and I don't even recall if I fully ported
>> it or just put up the start. I had some other stuff to deal with the last
>> few months, so my memory is a bit lacking. I'll review the code, meanwhile
>> ask whatever questions you have - lets get this fixed up. ~P
>>  > Date: Sun, 22 Apr 2012 22:10:27 +0300
>> > Subject: Spatial contrib bug fixing
>> > From: [EMAIL PROTECTED]
>> > To: [EMAIL PROTECTED]
>> >
>> > Hi all,
>> >
>> > We encountered several bugs with the Sparial contrb, and the ones we
>> tested
>> > with Java Lucene worked there (with 2.9.4). There are about 3 open
>> tickets
>> > in the Jira bug tracker on similar issues.
>> >
>> > I'm now sitting with the ultimate goal of fixing this once and for all,
>> but
>> > some code parts are commented out in favor of other not line-by-line
>> port
>> > of some implementations, without a comment giving reasons. I was
>> wondering
>> > if there's anyone who could answer a few questions there, instead of me
>> > changing things back and forth?
>> >
>> > Git history (I use the Git mirror, yes) tells me Prescott Nasser is
>> behind
>> > porting this - maybe he will have the answers?
>> >
>> > Cheers,
>> >
>> > Itamar.
>>
>>
>
>

When 3.0.3 was ported, there were lots of changes and so we have to work with re-porting all the contrib packages. (I think..)
 > Date: Mon, 23 Apr 2012 11:19:51 +0300
> Subject: Re: Spatial contrib bug fixing
> From: [EMAIL PROTECTED]
> To: [EMAIL PROTECTED]
>
> One more thing - what's the deal with ChainedFilter? I can see a commit by
> DIGY on 7/7/2011 but it seems to have been removed since?
>
> On Mon, Apr 23, 2012 at 11:06 AM, Itamar Syn-Hershko <[EMAIL PROTECTED]>wrote:
>
> > For starters - CartesianPolyFilterBuilder.GetBoxShape() is not an exact
> > port - do you remember why?
> >
> > Anyway, if it was never fully ported as you say maybe I'll just go ahead
> > and complete that
> >
> > For your reference, here are 2 failing tests which pass in Java Lucene
> > (can send the java file) -
> > https://github.com/synhershko/lucene.net/commit/234da7eca7cb08be5a0c2a7375ffc3f4a03bfd92
> >
> >
> >
> > On Mon, Apr 23, 2012 at 1:39 AM, Prescott Nasser <[EMAIL PROTECTED]>wrote:
> >
> >>
> >> I think that was a while ago, and I don't even recall if I fully ported
> >> it or just put up the start. I had some other stuff to deal with the last
> >> few months, so my memory is a bit lacking. I'll review the code, meanwhile
> >> ask whatever questions you have - lets get this fixed up. ~P
> >>  > Date: Sun, 22 Apr 2012 22:10:27 +0300
> >> > Subject: Spatial contrib bug fixing
> >> > From: [EMAIL PROTECTED]
> >> > To: [EMAIL PROTECTED]
> >> >
> >> > Hi all,
> >> >
> >> > We encountered several bugs with the Sparial contrb, and the ones we
> >> tested
> >> > with Java Lucene worked there (with 2.9.4). There are about 3 open
> >> tickets
> >> > in the Jira bug tracker on similar issues.
> >> >
> >> > I'm now sitting with the ultimate goal of fixing this once and for all,
> >> but
> >> > some code parts are commented out in favor of other not line-by-line
> >> port
> >> > of some implementations, without a comment giving reasons. I was
> >> wondering
> >> > if there's anyone who could answer a few questions there, instead of me
> >> > changing things back and forth?
> >> >
> >> > Git history (I use the Git mirror, yes) tells me Prescott Nasser is
> >> behind
> >> > porting this - maybe he will have the answers?
> >> >
> >> > Cheers,
> >> >
> >> > Itamar.
> >>
> >>
> >
> >
     

I'm having trouble finding chained filter in the java lucene svn... http://svn.apache.org/viewvc/lucene/dev/branches/branch_3x/lucene/contrib/?pathrev=990167 am I looking around in the wrong place?
 > Date: Mon, 23 Apr 2012 11:19:51 +0300
> Subject: Re: Spatial contrib bug fixing
> From: [EMAIL PROTECTED]
> To: [EMAIL PROTECTED]
>
> One more thing - what's the deal with ChainedFilter? I can see a commit by
> DIGY on 7/7/2011 but it seems to have been removed since?
>
> On Mon, Apr 23, 2012 at 11:06 AM, Itamar Syn-Hershko <[EMAIL PROTECTED]>wrote:
>
> > For starters - CartesianPolyFilterBuilder.GetBoxShape() is not an exact
> > port - do you remember why?
> >
> > Anyway, if it was never fully ported as you say maybe I'll just go ahead
> > and complete that
> >
> > For your reference, here are 2 failing tests which pass in Java Lucene
> > (can send the java file) -
> > https://github.com/synhershko/lucene.net/commit/234da7eca7cb08be5a0c2a7375ffc3f4a03bfd92
> >
> >
> >
> > On Mon, Apr 23, 2012 at 1:39 AM, Prescott Nasser <[EMAIL PROTECTED]>wrote:
> >
> >>
> >> I think that was a while ago, and I don't even recall if I fully ported
> >> it or just put up the start. I had some other stuff to deal with the last
> >> few months, so my memory is a bit lacking. I'll review the code, meanwhile
> >> ask whatever questions you have - lets get this fixed up. ~P
> >>  > Date: Sun, 22 Apr 2012 22:10:27 +0300
> >> > Subject: Spatial contrib bug fixing
> >> > From: [EMAIL PROTECTED]
> >> > To: [EMAIL PROTECTED]
> >> >
> >> > Hi all,
> >> >
> >> > We encountered several bugs with the Sparial contrb, and the ones we
> >> tested
> >> > with Java Lucene worked there (with 2.9.4). There are about 3 open
> >> tickets
> >> > in the Jira bug tracker on similar issues.
> >> >
> >> > I'm now sitting with the ultimate goal of fixing this once and for all,
> >> but
> >> > some code parts are commented out in favor of other not line-by-line
> >> port
> >> > of some implementations, without a comment giving reasons. I was
> >> wondering
> >> > if there's anyone who could answer a few questions there, instead of me
> >> > changing things back and forth?
> >> >
> >> > Git history (I use the Git mirror, yes) tells me Prescott Nasser is
> >> behind
> >> > porting this - maybe he will have the answers?
> >> >
> >> > Cheers,
> >> >
> >> > Itamar.
> >>
> >>
> >
> >
     

It's in a weird place.  And for the 3.0.3 version, its easiest to find the
code in the tags, rather than branches.

http://svn.apache.org/viewvc/lucene/java/tags/lucene_3_0_3/contrib/misc/src/java/org/apache/lucene/misc/
On Mon, Apr 23, 2012 at 2:20 PM, Prescott Nasser <[EMAIL PROTECTED]>wrote:

>
> I'm having trouble finding chained filter in the java lucene svn...
> http://svn.apache.org/viewvc/lucene/dev/branches/branch_3x/lucene/contrib/?pathrev=990167am I looking around in the wrong place?
>  > Date: Mon, 23 Apr 2012 11:19:51 +0300
> > Subject: Re: Spatial contrib bug fixing
> > From: [EMAIL PROTECTED]
> > To: [EMAIL PROTECTED]
> >
> > One more thing - what's the deal with ChainedFilter? I can see a commit
> by
> > DIGY on 7/7/2011 but it seems to have been removed since?
> >
> > On Mon, Apr 23, 2012 at 11:06 AM, Itamar Syn-Hershko <[EMAIL PROTECTED]
> >wrote:
> >
> > > For starters - CartesianPolyFilterBuilder.GetBoxShape() is not an exact
> > > port - do you remember why?
> > >
> > > Anyway, if it was never fully ported as you say maybe I'll just go
> ahead
> > > and complete that
> > >
> > > For your reference, here are 2 failing tests which pass in Java Lucene
> > > (can send the java file) -
> > >
> https://github.com/synhershko/lucene.net/commit/234da7eca7cb08be5a0c2a7375ffc3f4a03bfd92
> > >
> > >
> > >
> > > On Mon, Apr 23, 2012 at 1:39 AM, Prescott Nasser <
> [EMAIL PROTECTED]>wrote:
> > >
> > >>
> > >> I think that was a while ago, and I don't even recall if I fully
> ported
> > >> it or just put up the start. I had some other stuff to deal with the
> last
> > >> few months, so my memory is a bit lacking. I'll review the code,
> meanwhile
> > >> ask whatever questions you have - lets get this fixed up. ~P
> > >>  > Date: Sun, 22 Apr 2012 22:10:27 +0300
> > >> > Subject: Spatial contrib bug fixing
> > >> > From: [EMAIL PROTECTED]
> > >> > To: [EMAIL PROTECTED]
> > >> >
> > >> > Hi all,
> > >> >
> > >> > We encountered several bugs with the Sparial contrb, and the ones we
> > >> tested
> > >> > with Java Lucene worked there (with 2.9.4). There are about 3 open
> > >> tickets
> > >> > in the Jira bug tracker on similar issues.
> > >> >
> > >> > I'm now sitting with the ultimate goal of fixing this once and for
> all,
> > >> but
> > >> > some code parts are commented out in favor of other not line-by-line
> > >> port
> > >> > of some implementations, without a comment giving reasons. I was
> > >> wondering
> > >> > if there's anyone who could answer a few questions there, instead
> of me
> > >> > changing things back and forth?
> > >> >
> > >> > Git history (I use the Git mirror, yes) tells me Prescott Nasser is
> > >> behind
> > >> > porting this - maybe he will have the answers?
> > >> >
> > >> > Cheers,
> > >> >
> > >> > Itamar.
> > >>
> > >>
> > >
> > >
>
>

Uhm.. I was referring to the .NET port, which I can see DIGY ported

Nevermind I will get it from the original commit

@Prescott any idea re " CartesianPolyFilterBuilder.GetBoxShape() is not an
exact port - do you remember why? "?

On Tue, Apr 24, 2012 at 12:26 AM, Christopher Currens <
[EMAIL PROTECTED]> wrote:

> It's in a weird place.  And for the 3.0.3 version, its easiest to find the
> code in the tags, rather than branches.
>
>
> http://svn.apache.org/viewvc/lucene/java/tags/lucene_3_0_3/contrib/misc/src/java/org/apache/lucene/misc/
>
>
> On Mon, Apr 23, 2012 at 2:20 PM, Prescott Nasser <[EMAIL PROTECTED]
> >wrote:
>
> >
> > I'm having trouble finding chained filter in the java lucene svn...
> >
> http://svn.apache.org/viewvc/lucene/dev/branches/branch_3x/lucene/contrib/?pathrev=990167amI looking around in the wrong place?
> >  > Date: Mon, 23 Apr 2012 11:19:51 +0300
> > > Subject: Re: Spatial contrib bug fixing
> > > From: [EMAIL PROTECTED]
> > > To: [EMAIL PROTECTED]
> > >
> > > One more thing - what's the deal with ChainedFilter? I can see a commit
> > by
> > > DIGY on 7/7/2011 but it seems to have been removed since?
> > >
> > > On Mon, Apr 23, 2012 at 11:06 AM, Itamar Syn-Hershko <
> [EMAIL PROTECTED]
> > >wrote:
> > >
> > > > For starters - CartesianPolyFilterBuilder.GetBoxShape() is not an
> exact
> > > > port - do you remember why?
> > > >
> > > > Anyway, if it was never fully ported as you say maybe I'll just go
> > ahead
> > > > and complete that
> > > >
> > > > For your reference, here are 2 failing tests which pass in Java
> Lucene
> > > > (can send the java file) -
> > > >
> >
> https://github.com/synhershko/lucene.net/commit/234da7eca7cb08be5a0c2a7375ffc3f4a03bfd92
> > > >
> > > >
> > > >
> > > > On Mon, Apr 23, 2012 at 1:39 AM, Prescott Nasser <
> > [EMAIL PROTECTED]>wrote:
> > > >
> > > >>
> > > >> I think that was a while ago, and I don't even recall if I fully
> > ported
> > > >> it or just put up the start. I had some other stuff to deal with the
> > last
> > > >> few months, so my memory is a bit lacking. I'll review the code,
> > meanwhile
> > > >> ask whatever questions you have - lets get this fixed up. ~P
> > > >>  > Date: Sun, 22 Apr 2012 22:10:27 +0300
> > > >> > Subject: Spatial contrib bug fixing
> > > >> > From: [EMAIL PROTECTED]
> > > >> > To: [EMAIL PROTECTED]
> > > >> >
> > > >> > Hi all,
> > > >> >
> > > >> > We encountered several bugs with the Sparial contrb, and the ones
> we
> > > >> tested
> > > >> > with Java Lucene worked there (with 2.9.4). There are about 3 open
> > > >> tickets
> > > >> > in the Jira bug tracker on similar issues.
> > > >> >
> > > >> > I'm now sitting with the ultimate goal of fixing this once and for
> > all,
> > > >> but
> > > >> > some code parts are commented out in favor of other not
> line-by-line
> > > >> port
> > > >> > of some implementations, without a comment giving reasons. I was
> > > >> wondering
> > > >> > if there's anyone who could answer a few questions there, instead
> > of me
> > > >> > changing things back and forth?
> > > >> >
> > > >> > Git history (I use the Git mirror, yes) tells me Prescott Nasser
> is
> > > >> behind
> > > >> > porting this - maybe he will have the answers?
> > > >> >
> > > >> > Cheers,
> > > >> >
> > > >> > Itamar.
> > > >>
> > > >>
> > > >
> > > >
> >
> >
>

Robert Chapman ported Spatial to Lucene.NET, shown here in this issue:
https://issues.apache.org/jira/browse/LUCENENET-199.  DIGY only committed
the patch, and the only thing I've seen Prescott do was to
modify/apply LUCENENET-431 to trunk from 2.9.4g.  Spatial, along with the
rest of Contrib, was barely touched since Lucene.NET was resurrected into
the incubator.  Most, if not all, of the code is the exact same as the
patch contributed by Robert, which itself differed a decent amount from the
java code, so much of the reasons why it wasn't an exact port are either
lost, or the more likely case, never answered.

As far as I'm concerned, I have no qualms with you rewriting the thing from
scratch, if you wanted to pursue a more direct port from the java code.
 Aside from the original port which had many divergences from java, the
only other issue applied to spatial is LUCENENET-431, which would be easy
to include.
Thanks,
Christopher

On Tue, Apr 24, 2012 at 10:31 AM, Itamar Syn-Hershko <[EMAIL PROTECTED]>wrote:

> Uhm.. I was referring to the .NET port, which I can see DIGY ported
>
> Nevermind I will get it from the original commit
>
> @Prescott any idea re " CartesianPolyFilterBuilder.GetBoxShape() is not an
> exact port - do you remember why? "?
>
> On Tue, Apr 24, 2012 at 12:26 AM, Christopher Currens <
> [EMAIL PROTECTED]> wrote:
>
> > It's in a weird place.  And for the 3.0.3 version, its easiest to find
> the
> > code in the tags, rather than branches.
> >
> >
> >
> http://svn.apache.org/viewvc/lucene/java/tags/lucene_3_0_3/contrib/misc/src/java/org/apache/lucene/misc/
> >
> >
> > On Mon, Apr 23, 2012 at 2:20 PM, Prescott Nasser <[EMAIL PROTECTED]
> > >wrote:
> >
> > >
> > > I'm having trouble finding chained filter in the java lucene svn...
> > >
> >
> http://svn.apache.org/viewvc/lucene/dev/branches/branch_3x/lucene/contrib/?pathrev=990167amIlooking around in the wrong place?
> > >  > Date: Mon, 23 Apr 2012 11:19:51 +0300
> > > > Subject: Re: Spatial contrib bug fixing
> > > > From: [EMAIL PROTECTED]
> > > > To: [EMAIL PROTECTED]
> > > >
> > > > One more thing - what's the deal with ChainedFilter? I can see a
> commit
> > > by
> > > > DIGY on 7/7/2011 but it seems to have been removed since?
> > > >
> > > > On Mon, Apr 23, 2012 at 11:06 AM, Itamar Syn-Hershko <
> > [EMAIL PROTECTED]
> > > >wrote:
> > > >
> > > > > For starters - CartesianPolyFilterBuilder.GetBoxShape() is not an
> > exact
> > > > > port - do you remember why?
> > > > >
> > > > > Anyway, if it was never fully ported as you say maybe I'll just go
> > > ahead
> > > > > and complete that
> > > > >
> > > > > For your reference, here are 2 failing tests which pass in Java
> > Lucene
> > > > > (can send the java file) -
> > > > >
> > >
> >
> https://github.com/synhershko/lucene.net/commit/234da7eca7cb08be5a0c2a7375ffc3f4a03bfd92
> > > > >
> > > > >
> > > > >
> > > > > On Mon, Apr 23, 2012 at 1:39 AM, Prescott Nasser <
> > > [EMAIL PROTECTED]>wrote:
> > > > >
> > > > >>
> > > > >> I think that was a while ago, and I don't even recall if I fully
> > > ported
> > > > >> it or just put up the start. I had some other stuff to deal with
> the
> > > last
> > > > >> few months, so my memory is a bit lacking. I'll review the code,
> > > meanwhile
> > > > >> ask whatever questions you have - lets get this fixed up. ~P
> > > > >>  > Date: Sun, 22 Apr 2012 22:10:27 +0300
> > > > >> > Subject: Spatial contrib bug fixing
> > > > >> > From: [EMAIL PROTECTED]
> > > > >> > To: [EMAIL PROTECTED]
> > > > >> >
> > > > >> > Hi all,
> > > > >> >
> > > > >> > We encountered several bugs with the Sparial contrb, and the
> ones
> > we
> > > > >> tested
> > > > >> > with Java Lucene worked there (with 2.9.4). There are about 3
> open
> > > > >> tickets
> > > > >> > in the Jira bug tracker on similar issues.
> > > > >> >
> > > > >> > I'm now sitting with the ultimate goal of fixing this once and
> for
> > > all,
> > > > >> but
> > > > >

Thanks for your reply.
>  Aside from the original port which had many divergences from java, the
> only other issue applied to spatial is LUCENENET-431, which would be easy
> to include.
>
>
That is not correct. LUCENENET-431 was committed, but some fixed from Java
Lucene 3.0.3 are in as well. The whole thing is a mess.

The reason for this mess is the amount of bugs in the original Java
implementation of Spatial. This is also why it has been deprecated in 3.6:
https://issues.apache.org/jira/browse/LUCENE-2599

I think the best route at this point is to port LSP aka Spatial4j to .NET
and start using it as the Spatial module for Lucene.NET
https://issues.apache.org/jira/browse/LUCENE-3795

This is a Java Lucene 4 feature, but the current spatial implementation is
pretty unisable.

I'm going to start looking into this, and would definitely appreciate your
input.

Itamar.

Yes, the contrib is a MESS.  I've been favoring complete re-implementations
over porting changes, since contrib has been in such a poor, overlooked
state for so long.

I'm not opposed to porting LSP over the Spatial contrib project in Java,
though it will might some porting challenges both now, since Lucene
versions are different, and as Lucene.NET evolves.  It also might not, I'm
not familiar with the LSP code.  Contrib is just that, contributed software
that is not part of the core library, and there will be projects in Java we
can't port over.  In fact, I think there are .NET specific contrib projects
that aren't in java.  Either way, my point is that I'm am happy and willing
to have LSP included if that's going to wind up being better than Spatial.
 I think we can use all the help and contributions we can get in Lucene.NET.

Of course, we'd need to look and see what is possible, with porting over
LSP (not sure if it relies on any version specific features that may not
yet be in 3.0.3).  So, I say let's go for it, and if you need any help/want
to divide work between other committers, we can arrange that, and create
issues for it, that is, if the other committers don't object to this.

On Tue, Apr 24, 2012 at 1:45 PM, Itamar Syn-Hershko <[EMAIL PROTECTED]>wrote:

> Thanks for your reply.
>
>
> >  Aside from the original port which had many divergences from java, the
> > only other issue applied to spatial is LUCENENET-431, which would be easy
> > to include.
> >
> >
> That is not correct. LUCENENET-431 was committed, but some fixed from Java
> Lucene 3.0.3 are in as well. The whole thing is a mess.
>
> The reason for this mess is the amount of bugs in the original Java
> implementation of Spatial. This is also why it has been deprecated in 3.6:
> https://issues.apache.org/jira/browse/LUCENE-2599
>
> I think the best route at this point is to port LSP aka Spatial4j to .NET
> and start using it as the Spatial module for Lucene.NET
> https://issues.apache.org/jira/browse/LUCENE-3795
>
> This is a Java Lucene 4 feature, but the current spatial implementation is
> pretty unisable.
>
> I'm going to start looking into this, and would definitely appreciate your
> input.
>
> Itamar.
>

Great

The actual library lives outside of Lucene (
https://github.com/spatial4j/spatial4j ) and only some integration classes
are within the Lucene project itself. I linked to the (long) discussions
about this in my previous message. I will be following that approach with
this port, and really hope there will be no API differences I won't be able
to overcome.

I'm going to start doing this sometime tomorrow, but my main efforts will
be on Thursday. I can certainly use any help in dividing work etc - please
anyone who can join on Thursday for live collaboration or later chip in the
discussion.

I'll keep you posted.

On Wed, Apr 25, 2012 at 12:00 AM, Christopher Currens <
[EMAIL PROTECTED]> wrote:

> Yes, the contrib is a MESS.  I've been favoring complete re-implementations
> over porting changes, since contrib has been in such a poor, overlooked
> state for so long.
>
> I'm not opposed to porting LSP over the Spatial contrib project in Java,
> though it will might some porting challenges both now, since Lucene
> versions are different, and as Lucene.NET evolves.  It also might not, I'm
> not familiar with the LSP code.  Contrib is just that, contributed software
> that is not part of the core library, and there will be projects in Java we
> can't port over.  In fact, I think there are .NET specific contrib projects
> that aren't in java.  Either way, my point is that I'm am happy and willing
> to have LSP included if that's going to wind up being better than Spatial.
>  I think we can use all the help and contributions we can get in
> Lucene.NET.
>
> Of course, we'd need to look and see what is possible, with porting over
> LSP (not sure if it relies on any version specific features that may not
> yet be in 3.0.3).  So, I say let's go for it, and if you need any help/want
> to divide work between other committers, we can arrange that, and create
> issues for it, that is, if the other committers don't object to this.
>
> On Tue, Apr 24, 2012 at 1:45 PM, Itamar Syn-Hershko <[EMAIL PROTECTED]
> >wrote:
>
> > Thanks for your reply.
> >
> >
> > >  Aside from the original port which had many divergences from java, the
> > > only other issue applied to spatial is LUCENENET-431, which would be
> easy
> > > to include.
> > >
> > >
> > That is not correct. LUCENENET-431 was committed, but some fixed from
> Java
> > Lucene 3.0.3 are in as well. The whole thing is a mess.
> >
> > The reason for this mess is the amount of bugs in the original Java
> > implementation of Spatial. This is also why it has been deprecated in
> 3.6:
> > https://issues.apache.org/jira/browse/LUCENE-2599
> >
> > I think the best route at this point is to port LSP aka Spatial4j to .NET
> > and start using it as the Spatial module for Lucene.NET
> > https://issues.apache.org/jira/browse/LUCENE-3795
> >
> > This is a Java Lucene 4 feature, but the current spatial implementation
> is
> > pretty unisable.
> >
> > I'm going to start looking into this, and would definitely appreciate
> your
> > input.
> >
> > Itamar.
> >
>

Before we start, I almost forgot, we need to make sure that it can actually
be ported into the project, according to ASF guidelines.  I *think* it
should be okay, because it's licensed under the Apache 2.0 license, but we
should get some feedback from our mentors, on whether this is okay.

Stefan, are there any problems with porting code from a non-apache project
that is licensed under the Apache 2.0 license?

On Tue, Apr 24, 2012 at 2:14 PM, Itamar Syn-Hershko <[EMAIL PROTECTED]>wrote:

> Great
>
> The actual library lives outside of Lucene (
> https://github.com/spatial4j/spatial4j ) and only some integration classes
> are within the Lucene project itself. I linked to the (long) discussions
> about this in my previous message. I will be following that approach with
> this port, and really hope there will be no API differences I won't be able
> to overcome.
>
> I'm going to start doing this sometime tomorrow, but my main efforts will
> be on Thursday. I can certainly use any help in dividing work etc - please
> anyone who can join on Thursday for live collaboration or later chip in the
> discussion.
>
> I'll keep you posted.
>
> On Wed, Apr 25, 2012 at 12:00 AM, Christopher Currens <
> [EMAIL PROTECTED]> wrote:
>
> > Yes, the contrib is a MESS.  I've been favoring complete
> re-implementations
> > over porting changes, since contrib has been in such a poor, overlooked
> > state for so long.
> >
> > I'm not opposed to porting LSP over the Spatial contrib project in Java,
> > though it will might some porting challenges both now, since Lucene
> > versions are different, and as Lucene.NET evolves.  It also might not,
> I'm
> > not familiar with the LSP code.  Contrib is just that, contributed
> software
> > that is not part of the core library, and there will be projects in Java
> we
> > can't port over.  In fact, I think there are .NET specific contrib
> projects
> > that aren't in java.  Either way, my point is that I'm am happy and
> willing
> > to have LSP included if that's going to wind up being better than
> Spatial.
> >  I think we can use all the help and contributions we can get in
> > Lucene.NET.
> >
> > Of course, we'd need to look and see what is possible, with porting over
> > LSP (not sure if it relies on any version specific features that may not
> > yet be in 3.0.3).  So, I say let's go for it, and if you need any
> help/want
> > to divide work between other committers, we can arrange that, and create
> > issues for it, that is, if the other committers don't object to this.
> >
> > On Tue, Apr 24, 2012 at 1:45 PM, Itamar Syn-Hershko <[EMAIL PROTECTED]
> > >wrote:
> >
> > > Thanks for your reply.
> > >
> > >
> > > >  Aside from the original port which had many divergences from java,
> the
> > > > only other issue applied to spatial is LUCENENET-431, which would be
> > easy
> > > > to include.
> > > >
> > > >
> > > That is not correct. LUCENENET-431 was committed, but some fixed from
> > Java
> > > Lucene 3.0.3 are in as well. The whole thing is a mess.
> > >
> > > The reason for this mess is the amount of bugs in the original Java
> > > implementation of Spatial. This is also why it has been deprecated in
> > 3.6:
> > > https://issues.apache.org/jira/browse/LUCENE-2599
> > >
> > > I think the best route at this point is to port LSP aka Spatial4j to
> .NET
> > > and start using it as the Spatial module for Lucene.NET
> > > https://issues.apache.org/jira/browse/LUCENE-3795
> > >
> > > This is a Java Lucene 4 feature, but the current spatial implementation
> > is
> > > pretty unisable.
> > >
> > > I'm going to start looking into this, and would definitely appreciate
> > your
> > > input.
> > >
> > > Itamar.
> > >
> >
>