FieldsEnum seems kinda awkward, can we just have something like
Iterable<String> on Fields?

so the consuming code i think would be easier.

for (String field : fields) {
  Terms terms = fields.terms(field);
  ...
}

I don't like that there are two ways to get the terms for a field
today, so there is duplicate logic or crazy
stuff to handle this Fields.terms(String) versus FieldsEnum.terms()

--
lucidimagination.com

---------------------------------------------------------------------

+1

Mike McCandless

http://blog.mikemccandless.com
On Sat, Aug 11, 2012 at 9:27 AM, Robert Muir <[EMAIL PROTECTED]> wrote:
> FieldsEnum seems kinda awkward, can we just have something like
> Iterable<String> on Fields?
>
> so the consuming code i think would be easier.
>
> for (String field : fields) {
>   Terms terms = fields.terms(field);
>   ...
> }
>
> I don't like that there are two ways to get the terms for a field
> today, so there is duplicate logic or crazy
> stuff to handle this Fields.terms(String) versus FieldsEnum.terms()
>
> --
> lucidimagination.com
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>

---------------------------------------------------------------------

Here's a patch: http://pastebin.com/PQGSgBtT

On Sat, Aug 11, 2012 at 9:29 AM, Michael McCandless
<[EMAIL PROTECTED]> wrote:
> +1
>
> Mike McCandless
>
> http://blog.mikemccandless.com
>
>
> On Sat, Aug 11, 2012 at 9:27 AM, Robert Muir <[EMAIL PROTECTED]> wrote:
>> FieldsEnum seems kinda awkward, can we just have something like
>> Iterable<String> on Fields?
>>
>> so the consuming code i think would be easier.
>>
>> for (String field : fields) {
>>   Terms terms = fields.terms(field);
>>   ...
>> }
>>
>> I don't like that there are two ways to get the terms for a field
>> today, so there is duplicate logic or crazy
>> stuff to handle this Fields.terms(String) versus FieldsEnum.terms()
>>
>> --
>> lucidimagination.com
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>> For additional commands, e-mail: [EMAIL PROTECTED]
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>

--
lucidworks.com

---------------------------------------------------------------------

Is there a JIRA issue for it? The patch is large and the issue seems
important enough to be handled through JIRA?

Shai

On Sun, Aug 12, 2012 at 4:53 AM, Robert Muir <[EMAIL PROTECTED]> wrote:

> Here's a patch: http://pastebin.com/PQGSgBtT
>
> On Sat, Aug 11, 2012 at 9:29 AM, Michael McCandless
> <[EMAIL PROTECTED]> wrote:
> > +1
> >
> > Mike McCandless
> >
> > http://blog.mikemccandless.com
> >
> >
> > On Sat, Aug 11, 2012 at 9:27 AM, Robert Muir <[EMAIL PROTECTED]> wrote:
> >> FieldsEnum seems kinda awkward, can we just have something like
> >> Iterable<String> on Fields?
> >>
> >> so the consuming code i think would be easier.
> >>
> >> for (String field : fields) {
> >>   Terms terms = fields.terms(field);
> >>   ...
> >> }
> >>
> >> I don't like that there are two ways to get the terms for a field
> >> today, so there is duplicate logic or crazy
> >> stuff to handle this Fields.terms(String) versus FieldsEnum.terms()
> >>
> >> --
> >> lucidimagination.com
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: [EMAIL PROTECTED]
> >> For additional commands, e-mail: [EMAIL PROTECTED]
> >>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > For additional commands, e-mail: [EMAIL PROTECTED]
> >
>
>
>
> --
> lucidworks.com
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>

JIRA has been down for a while now. We can't just stop development
because of this: personally I will just continue working and sending
patches to the list for review.

If someone wants, they can create JIRAs for these things after the
fact: but I'm not letting it get in my way.

On Sun, Aug 12, 2012 at 1:13 AM, Shai Erera <[EMAIL PROTECTED]> wrote:
> Is there a JIRA issue for it? The patch is large and the issue seems
> important enough to be handled through JIRA?
>
> Shai
>
>
> On Sun, Aug 12, 2012 at 4:53 AM, Robert Muir <[EMAIL PROTECTED]> wrote:
>>
>> Here's a patch: http://pastebin.com/PQGSgBtT
>>
>> On Sat, Aug 11, 2012 at 9:29 AM, Michael McCandless
>> <[EMAIL PROTECTED]> wrote:
>> > +1
>> >
>> > Mike McCandless
>> >
>> > http://blog.mikemccandless.com
>> >
>> >
>> > On Sat, Aug 11, 2012 at 9:27 AM, Robert Muir <[EMAIL PROTECTED]> wrote:
>> >> FieldsEnum seems kinda awkward, can we just have something like
>> >> Iterable<String> on Fields?
>> >>
>> >> so the consuming code i think would be easier.
>> >>
>> >> for (String field : fields) {
>> >>   Terms terms = fields.terms(field);
>> >>   ...
>> >> }
>> >>
>> >> I don't like that there are two ways to get the terms for a field
>> >> today, so there is duplicate logic or crazy
>> >> stuff to handle this Fields.terms(String) versus FieldsEnum.terms()
>> >>
>> >> --
>> >> lucidimagination.com
>> >>
>> >> ---------------------------------------------------------------------
>> >> To unsubscribe, e-mail: [EMAIL PROTECTED]
>> >> For additional commands, e-mail: [EMAIL PROTECTED]
>> >>
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: [EMAIL PROTECTED]
>> > For additional commands, e-mail: [EMAIL PROTECTED]
>> >
>>
>>
>>
>> --
>> lucidworks.com
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>> For additional commands, e-mail: [EMAIL PROTECTED]
>>
>

--
lucidimagination.com

---------------------------------------------------------------------

Ah I see.

Shai

On Sun, Aug 12, 2012 at 8:32 AM, Robert Muir <[EMAIL PROTECTED]> wrote:

> JIRA has been down for a while now. We can't just stop development
> because of this: personally I will just continue working and sending
> patches to the list for review.
>
> If someone wants, they can create JIRAs for these things after the
> fact: but I'm not letting it get in my way.
>
> On Sun, Aug 12, 2012 at 1:13 AM, Shai Erera <[EMAIL PROTECTED]> wrote:
> > Is there a JIRA issue for it? The patch is large and the issue seems
> > important enough to be handled through JIRA?
> >
> > Shai
> >
> >
> > On Sun, Aug 12, 2012 at 4:53 AM, Robert Muir <[EMAIL PROTECTED]> wrote:
> >>
> >> Here's a patch: http://pastebin.com/PQGSgBtT
> >>
> >> On Sat, Aug 11, 2012 at 9:29 AM, Michael McCandless
> >> <[EMAIL PROTECTED]> wrote:
> >> > +1
> >> >
> >> > Mike McCandless
> >> >
> >> > http://blog.mikemccandless.com
> >> >
> >> >
> >> > On Sat, Aug 11, 2012 at 9:27 AM, Robert Muir <[EMAIL PROTECTED]>
> wrote:
> >> >> FieldsEnum seems kinda awkward, can we just have something like
> >> >> Iterable<String> on Fields?
> >> >>
> >> >> so the consuming code i think would be easier.
> >> >>
> >> >> for (String field : fields) {
> >> >>   Terms terms = fields.terms(field);
> >> >>   ...
> >> >> }
> >> >>
> >> >> I don't like that there are two ways to get the terms for a field
> >> >> today, so there is duplicate logic or crazy
> >> >> stuff to handle this Fields.terms(String) versus FieldsEnum.terms()
> >> >>
> >> >> --
> >> >> lucidimagination.com
> >> >>
> >> >> ---------------------------------------------------------------------
> >> >> To unsubscribe, e-mail: [EMAIL PROTECTED]
> >> >> For additional commands, e-mail: [EMAIL PROTECTED]
> >> >>
> >> >
> >> > ---------------------------------------------------------------------
> >> > To unsubscribe, e-mail: [EMAIL PROTECTED]
> >> > For additional commands, e-mail: [EMAIL PROTECTED]
> >> >
> >>
> >>
> >>
> >> --
> >> lucidworks.com
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: [EMAIL PROTECTED]
> >> For additional commands, e-mail: [EMAIL PROTECTED]
> >>
> >
>
>
>
> --
> lucidimagination.com
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>

+1, another great cleanup!

Mike McCandless

http://blog.mikemccandless.com

On Sat, Aug 11, 2012 at 9:53 PM, Robert Muir <[EMAIL PROTECTED]> wrote:
> Here's a patch: http://pastebin.com/PQGSgBtT
>
> On Sat, Aug 11, 2012 at 9:29 AM, Michael McCandless
> <[EMAIL PROTECTED]> wrote:
>> +1
>>
>> Mike McCandless
>>
>> http://blog.mikemccandless.com
>>
>>
>> On Sat, Aug 11, 2012 at 9:27 AM, Robert Muir <[EMAIL PROTECTED]> wrote:
>>> FieldsEnum seems kinda awkward, can we just have something like
>>> Iterable<String> on Fields?
>>>
>>> so the consuming code i think would be easier.
>>>
>>> for (String field : fields) {
>>>   Terms terms = fields.terms(field);
>>>   ...
>>> }
>>>
>>> I don't like that there are two ways to get the terms for a field
>>> today, so there is duplicate logic or crazy
>>> stuff to handle this Fields.terms(String) versus FieldsEnum.terms()
>>>
>>> --
>>> lucidimagination.com
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>>> For additional commands, e-mail: [EMAIL PROTECTED]
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>> For additional commands, e-mail: [EMAIL PROTECTED]
>>
>
>
>
> --
> lucidworks.com
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>

---------------------------------------------------------------------