|
|
-
BitVector.get bounds checking
Jason Rutherglen 2009-02-03, 18:58
A simple way to make BitVector faster would be to turn the get method bounds checking into an assertion. This is similar to OpenBitSet.fastGet.
+
Jason Rutherglen 2009-02-03, 18:58
-
Re: BitVector.get bounds checking
Michael McCandless 2009-02-03, 19:38
I think that makes sense. I'll wait a day or so and then commit it if there are no objections.
Mike
Jason Rutherglen wrote:
> A simple way to make BitVector faster would be to turn the get method > bounds checking into an assertion. This is similar to > OpenBitSet.fastGet. ---------------------------------------------------------------------
+
Michael McCandless 2009-02-03, 19:38
-
Re: BitVector.get bounds checking
Andi Vajda 2009-02-03, 19:57
Isn't that depending on Java 1.5 ?
Andi..
On Feb 3, 2009, at 11:38, Michael McCandless <[EMAIL PROTECTED]> wrote:
> > I think that makes sense. I'll wait a day or so and then commit it > if there are no objections. > > Mike > > Jason Rutherglen wrote: > >> A simple way to make BitVector faster would be to turn the get method >> bounds checking into an assertion. This is similar to >> OpenBitSet.fastGet. > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] >
---------------------------------------------------------------------
+
Andi Vajda 2009-02-03, 19:57
-
Re: BitVector.get bounds checking
Michael McCandless 2009-02-03, 20:00
Do you mean the assert statement? That's available since 1.4.
Mike
Andi Vajda wrote:
> Isn't that depending on Java 1.5 ? > > Andi.. > > On Feb 3, 2009, at 11:38, Michael McCandless <[EMAIL PROTECTED] > > wrote: > >> >> I think that makes sense. I'll wait a day or so and then commit it >> if there are no objections. >> >> Mike >> >> Jason Rutherglen wrote: >> >>> A simple way to make BitVector faster would be to turn the get >>> method >>> bounds checking into an assertion. This is similar to >>> OpenBitSet.fastGet. >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [EMAIL PROTECTED] >> For additional commands, e-mail: [EMAIL PROTECTED] >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > ---------------------------------------------------------------------
+
Michael McCandless 2009-02-03, 20:00
-
Re: BitVector.get bounds checking
Andi Vajda 2009-02-03, 20:54
On Tue, 3 Feb 2009, Michael McCandless wrote:
> Do you mean the assert statement? That's available since 1.4.
Yeah, that's what I meant. 1.5 vs 1.4 is getting blurry :)
Andi..
> > Mike > > Andi Vajda wrote: > >> Isn't that depending on Java 1.5 ? >> >> Andi.. >> >> On Feb 3, 2009, at 11:38, Michael McCandless <[EMAIL PROTECTED]> >> wrote: >> >>> >>> I think that makes sense. I'll wait a day or so and then commit it if >>> there are no objections. >>> >>> Mike >>> >>> Jason Rutherglen wrote: >>> >>>> A simple way to make BitVector faster would be to turn the get method >>>> bounds checking into an assertion. This is similar to >>>> OpenBitSet.fastGet. >>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: [EMAIL PROTECTED] >>> For additional commands, e-mail: [EMAIL PROTECTED] >>> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [EMAIL PROTECTED] >> For additional commands, e-mail: [EMAIL PROTECTED] >> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] >
---------------------------------------------------------------------
+
Andi Vajda 2009-02-03, 20:54
-
Re: BitVector.get bounds checking
Michael McCandless 2009-02-03, 20:56
Tell me about it! We gotta get 2.9/3.0 out, so we can switch to 1.5. The 1.5/1.6 line is less blurry :)
Mike
Andi Vajda wrote:
> > On Tue, 3 Feb 2009, Michael McCandless wrote: > >> Do you mean the assert statement? That's available since 1.4. > > Yeah, that's what I meant. 1.5 vs 1.4 is getting blurry :) > > Andi.. > >> >> Mike >> >> Andi Vajda wrote: >> >>> Isn't that depending on Java 1.5 ? >>> Andi.. >>> On Feb 3, 2009, at 11:38, Michael McCandless <[EMAIL PROTECTED] >>> > wrote: >>>> I think that makes sense. I'll wait a day or so and then commit >>>> it if there are no objections. >>>> Mike >>>> Jason Rutherglen wrote: >>>>> A simple way to make BitVector faster would be to turn the get >>>>> method >>>>> bounds checking into an assertion. This is similar to >>>>> OpenBitSet.fastGet. >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: [EMAIL PROTECTED] >>>> For additional commands, e-mail: [EMAIL PROTECTED] >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: [EMAIL PROTECTED] >>> For additional commands, e-mail: [EMAIL PROTECTED] >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [EMAIL PROTECTED] >> For additional commands, e-mail: [EMAIL PROTECTED] >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > ---------------------------------------------------------------------
+
Michael McCandless 2009-02-03, 20:56
-
RE: BitVector.get bounds checking
Uwe Schindler 2009-02-03, 20:03
Hi Andi,
> Isn't that depending on Java 1.5 ?
Assertions work since Java 1.4 I think. We have a lot of assertions in code. And it would not compile with -source 1.4, as we do.
> <[EMAIL PROTECTED]> wrote: > > > > > I think that makes sense. I'll wait a day or so and then commit it > > if there are no objections. > > > > Mike > > > > Jason Rutherglen wrote: > > > >> A simple way to make BitVector faster would be to turn the get method > >> bounds checking into an assertion. This is similar to > >> OpenBitSet.fastGet. > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
+
Uwe Schindler 2009-02-03, 20:03
|
|